layers: Move command counting to CMD_BUFFER_STATE::RecordCmd() #3184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-ValidationLayers build queued with queue ID 21545. |
|
CI Vulkan-ValidationLayers build # 4451 running. |
|
CI Vulkan-ValidationLayers build # 4451 failed. |
This method can be overriden by validation objects to do more detailed tracking, if desired. Add RecordStateCmd() and RecordTransferCmd() to clean up repeated code blobs found in many commands.
Move some of the sync related helper methods to the CMD_BUFFER_STATE file, before moving them to that class. The only part of this change that isn't a straight cut / paste is ValidationStateTracker::RecordCmdWriteTimestamp() which will only exist until the next commit.
Convert sync related ValidationStateTracker methods to be CMD_BUFFER_STATE methods. This change also adds RecordCmd() calls to them.
jeremyg-lunarg
force-pushed
the
jeremyg-record-cmd
branch
from
2433e4a to
2d3f0d5
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 21604. |
|
CI Vulkan-ValidationLayers build # 4453 running. |
|
CI Vulkan-ValidationLayers build # 4453 passed. |
|
FYI @nadavgevaAMD you should be able to override RecordCmd() to track all of the commands in a vector. |
|
@jeremyg-lunarg -- I wonder if we should coordinate command tagging efforts s.t. tagging is consistent between syncval and the other efforts. |
ncesario-lunarg
approved these changes
Aug 18, 2021
Sure... Lets talk offline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method can be overriden by validation objects to do more detailed tracking, if desired.
Move some parts of command recording to CMD_BUFFER_STATE.