Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corechecks: Remove extra CommandBuffer, Image and ImageView Get<> calls #3550

Merged

Conversation

jeremyg-lunarg
Copy link
Contributor

Avoid 2-3 lookups of the same CommandBuffer handle in each draw call.

Fix yet another place where ImageView and Images are needlessly lookedup.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 2956.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 5543 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 5543 passed.

Copy link
Contributor

@TonyBarbour TonyBarbour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeremyg-lunarg jeremyg-lunarg merged commit 5c2548a into KhronosGroup:master Nov 19, 2021
@jeremyg-lunarg jeremyg-lunarg deleted the jeremyg-remove-cb-get branch November 19, 2021 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants