corechecks: Remove extra GetRead() call in dynamic rendering #3687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValidateRenderingAttachmentInfoKHR() doesn't need to access command buffer state. Its calling code already has a read-locked command buffer, so this extra call could lead to deadlock.
|
CI Vulkan-ValidationLayers build queued with queue ID 19590. |
ncesario-lunarg
approved these changes
Jan 19, 2022
|
CI Vulkan-ValidationLayers build # 5984 running. |
|
CI Vulkan-ValidationLayers build # 5984 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ValidateRenderingAttachmentInfoKHR() doesn't need to access
command buffer state. Its calling code already has a read-locked
command buffer, so this extra call could lead to deadlock.