layers: Move all settings to VK_EXT_layer_settings #8549
Conversation
|
CI Vulkan-ValidationLayers build queued with queue ID 257667. |
| // These aim to follow VkDebugReportFlagBitsEXT but were created prior | ||
| // Could replace with VkDebugReportFlagBitsEXT, but would be a LOT of churn and these | ||
| // names are less verbose and desired. | ||
| enum LogMessageTypeBits { |
There was a problem hiding this comment.
this gets included from both layer and tests, decided to make a dedicated file as this should never be touched and I only want the minimal ./layer code in ./test as possible
| @@ -676,6 +676,49 @@ VKAPI_ATTR VkBool32 VKAPI_CALL MessengerBreakCallback([[maybe_unused]] VkDebugUt | |||
| return false; | |||
| } | |||
|
|
|||
| static void PrintMessageSeverity(VkFlags vk_flags, char *msg_flags) { | |||
There was a problem hiding this comment.
just moving here as only place it is used
| @@ -16,64 +16,9 @@ | |||
| **************************************************************************/ | |||
There was a problem hiding this comment.
this file basically has just become a way to call GetEnvironment
might move this logic to another file, but for now going to just leave here
|
CI Vulkan-ValidationLayers build # 17483 running. |
| @@ -250,197 +127,6 @@ static inline bool IsHighIntegrity() { | |||
| } | |||
| #endif | |||
|
|
|||
| string ConfigFile::FindSettings() { | |||
There was a problem hiding this comment.
all this logic was replaced with VK_EXT_layer_settings, we were duplicating its logic here
| if (debug_action & VK_DBG_LAYER_ACTION_LOG_MSG) { | ||
| FILE *log_output = GetLayerLogOutput(log_filename.c_str()); | ||
| if (log_output != stdout) { | ||
| printf("Validation Layer Info - Logging validation error to %s\n", log_filename.c_str()); |
There was a problem hiding this comment.
this single handly is so nice, i have sometimes had issues trying to log to a file and having confirmation that it is hooked up is awesome
spencer-lunarg
force-pushed
the
spencer-lunarg-settings-9000
branch
from
b6ea27e to
d9f7482
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 257682. |
|
CI Vulkan-ValidationLayers build # 17484 running. |
|
CI Vulkan-ValidationLayers build # 17484 passed. |
spencer-lunarg
force-pushed
the
spencer-lunarg-settings-9000
branch
from
d9f7482 to
3d8205f
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 258125. |
|
CI Vulkan-ValidationLayers build # 17493 running. |
|
CI Vulkan-ValidationLayers build queued with queue ID 258142. |
|
CI Vulkan-ValidationLayers build # 17494 running. |
|
CI Vulkan-ValidationLayers build # 17494 failed. |
spencer-lunarg
force-pushed
the
spencer-lunarg-settings-9000
branch
from
94c9f28 to
1fae7ea
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 258225. |
|
CI Vulkan-ValidationLayers build # 17498 running. |
|
CI Vulkan-ValidationLayers build # 17498 passed. |
|
CI Vulkan-ValidationLayers build queued with queue ID 258316. |
|
CI Vulkan-ValidationLayers build # 17499 running. |
|
CI Vulkan-ValidationLayers build # 17499 passed. |
closes #8477
I have wanted to do this for a long time
VK_LAYER_LOG_FILENAME,VK_LAYER_DEBUG_ACTION, andVK_LAYER_REPORT_FLAGcould never be set by environment variables and used old code that was solved by usingvkuCreateLayerSettingSetviaVK_EXT_layer_settingThis moves the code over, as well as adds some more useful info when setting non-default settings