Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: Convert NegativeSyncVal.BufferCopy errors to new style #9369

Merged

Conversation

artem-lunarg
Copy link
Contributor

Used NegativeSyncVal.BufferCopy test as work scope to convert its errors to new style. Code is of r&d style (ugly), the focus it to finalize message structure first. Need to go over more use cases to have better idea which formatting helpers will be needed.

WRITE_AFTER_READ hazard for buffer copy without barrier:
OLD:

vkCmdCopyBuffer(): Hazard WRITE_AFTER_READ for dstBuffer VkBuffer 0xf56c9b0000000004[], region 0. Access info (usage: SYNC_COPY_TRANSFER_WRITE, prior_usage: SYNC_COPY_TRANSFER_READ, read_barriers: VkPipelineStageFlags2(0), command: vkCmdCopyBuffer, resource: VkBuffer 0xf56c9b0000000004[]).

NEW:

vkCmdCopyBuffer(): WRITE_AFTER_READ hazard detected. vkCmdCopyBuffer writes to VkBuffer 0xf56c9b0000000004[], which was previously read by another vkCmdCopyBuffer command. No sufficient synchronization is present to ensure that a write (VK_ACCESS_2_TRANSFER_WRITE_BIT) at the VK_PIPELINE_STAGE_2_COPY_BIT stage does not conflict with a prior read (VK_ACCESS_2_TRANSFER_READ_BIT) at the same stage. An execution dependency is sufficient to prevent this hazard.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 362039.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18956 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18956 passed.

@artem-lunarg artem-lunarg marked this pull request as ready for review January 31, 2025 18:19
@artem-lunarg artem-lunarg requested a review from a team as a code owner January 31, 2025 18:19
@artem-lunarg artem-lunarg merged commit a6bdee8 into KhronosGroup:main Jan 31, 2025
20 checks passed
@artem-lunarg artem-lunarg deleted the artem-sync-buffer-error branch January 31, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants