Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default thickness value #1686

Closed
emackey opened this issue Jul 19, 2022 · 0 comments · Fixed by #1700
Closed

Default thickness value #1686

emackey opened this issue Jul 19, 2022 · 0 comments · Fixed by #1700

Comments

@emackey
Copy link
Member

emackey commented Jul 19, 2022

Hi, following #1646 in the updated "glTF Settings" node, the "thickness" value should default to zero, not one. This matches glTF's own default thicknessFactor of zero.

I think it's appropriate to write KHR_materials_volume on export when (a) thickness is non-zero or textured, and (b) transmission is non-zero or textured. This can have an effect even in cases where absorption/attenuation/density is not being used on the volume.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants