Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename glTF Settings to glTF Material Output #1698

Merged
merged 2 commits into from
Aug 6, 2022
Merged

rename glTF Settings to glTF Material Output #1698

merged 2 commits into from
Aug 6, 2022

Conversation

julienduroure
Copy link
Collaborator

Part of #1694

@julienduroure julienduroure changed the base branch from master to blender-v3.3-release August 5, 2022 09:36
@julienduroure
Copy link
Collaborator Author

@donmccurdy

@julienduroure julienduroure added this to the Blender 3.3 milestone Aug 5, 2022
donmccurdy
donmccurdy approved these changes Aug 5, 2022
View reviewed changes
Copy link
Contributor

@donmccurdy donmccurdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer this update because it's very consistent with "Material Output", but wanted to check this sounds okay to others — @emackey any preference?

Thanks for including backward-compatibility with the previous name as well!

emackey
emackey approved these changes Aug 5, 2022
View reviewed changes
Copy link
Member

@emackey emackey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me.

@julienduroure julienduroure merged commit 1da708f into blender-v3.3-release Aug 6, 2022
@julienduroure julienduroure deleted the rename_gltf_settings_node branch August 6, 2022 10:06
@AHugoson AHugoson mentioned this pull request Oct 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emackey emackey emackey approved these changes

@donmccurdy donmccurdy donmccurdy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Blender 3.3
Development

Successfully merging this pull request may close these issues.
3 participants
@julienduroure @emackey @donmccurdy