Import: prettify bones #946
Conversation
...instead of adding an extra node.
Since edit bones point along their local +Y axis, this will let us pick the way they point. As a demonstration this works, rotate all bones back to the way they used to point before the vnode code was merged.
To demonstrate it works, set all lengths to 0.5
When we don't change coordinates, also don't change bone rotations. This makes it easier to see what axis a bone points along in glTF: import with debug_value == 100 and turn on display axes for the armature.
julienduroure
added
enhancement
|
Will this make the 2.83 release? |
|
Yes, plan is to get it in time for 2.83, if everything get smooth |
|
Do you know what it'll take to have an option that'll force align it to https://github.com/pixiv/three-vrm/blob/v0.3.0/src/vrm/material/shaders/mtoon.frag standards? I'm not sure the exact details. It's something like make all bone rotations line up with the global axes. |
|
@fire Not sure what you're asking. What should I be looking for in that fragment shader? |
My bad, I posted the relevant page. I'm not sure where to put this report, but here sounds like a good place for an option. |
|
Every tests I did are OK :) |
This is for forwards compatibility. A future heuristic might also affect bone lengths, not just tips.
|
No problem.
This PR contains all the commits from #945 (branch for #945 is pointing at the second commit here).
Mostly because it depends on #945. Do you want to change anything about the new option though? Since it'll be part of the UI/Python API. I just changed Eg. different name than "Temperance"? "strategy" instead of "heuristic"? |
|
"Temperance Strategy" sounds better. I don't see people use the word heuristic often. |
|
Well, English is not my primary language, so not sure what is better |
|
Merged :) |
Depends on #945. You can see how the local rotation stuff gets used if you want.
Fixes #324.
Also see #455.
This attempts to rotate/resize edit bones so they're more readable. It's based on some simple heuristics. There's lots of stuff that you might want to do differently, but I think this is a good start. Anyway all the tools to set lengths and rotate editbones are now in place at least.
An import option was added to control the heuristic for bone directions (it doesn't affect bone lengths). The only two options currently are:
Blender (+Y)
This rotates bones so their tips lie on their local +Y axis (in glTF space). This option will round-trip bone directions when re-importing models exported from Blender.
(Also see #879)
Temperance (this is the default)
Name is provisional. It works well for many different models so I made it the default. It tries to place the bone tip on whichever axis is closest to the centroid of its children. Leaf bones are rotated the same way as their parents.
Generally it's not too bad for character models at least.