-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JOINT_MATRIX or JOINTMATRIX? #187
Comments
another option is just |
This is also OK with me, but the question still remains for names of semantics, e.g., |
I personally prefer |
I am OK with keeping no underscores (e.g., @fabrobinet do you agree? If so I will update the schema for |
I agree. consistency first no underscores.... + flagged for converter |
Schema is updated. b20d1cf |
The schema and the converter are updated. |
The naming convention for
JOINT_MATRIX
is inconsistent with the rest of the uniform semantics in #83. However, they are inconsistent with WebGL naming conventions, e.g.,FLOAT_VEC3
.We can:
JOINT_MATRIX
to JOINTMATRIX`.MODELVIEWPROJECTION
toMODEL_VIEW_PROJECTION
Perhaps the last option is best.
The text was updated successfully, but these errors were encountered: