-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schema updates #241
Schema updates #241
Conversation
Captain obvious here, noting that a single tab used for indentation in some of these changes, while the original code uses four spaces. |
@pjcozzi do you think you can you merge this PR this week ? |
No, it will be the week of August 4 given the August 1 Cesium release. |
@fabrobinet I am closing this and will re-open a PR from schema-8 shortly - I just need to tweak the render states and read over the README.md. |
ok @pjcozzi thanks for the heads up and the hard work on that one |
This is a pull request from the
schema
branch to a newspec
branch where I will make spec changes (maybe in time for GDC, no promises though!). Once the schema and spec are synced, I'll open another pull request to mergespec
tomaster
.This brings the JSON schema up-to-date with the glTF JSON produced by the converter in
master
. This still needs a few things before merging.description
properties throughoutstates
schema for state parameters should be an array instead of a list of named parameters #85 (could be done later)There are several issues open with the specification label, but we don't need to address all of them right away. I am more concerned about getting the schema in sync with the converter and then keeping them in sync.
We will also have a small open-source JavaScript library that takes a root glTF object and adds missing properties that have default values, e.g., use identity if
matrix.node
and TRS properties areundefined
. This will make it easy to work with the converter option that excludes properties set to their default values. The source is currently here, but it needs more testing and to be moved to its own repo.