Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better version info #229

Closed
RemiArnaud opened this issue Feb 16, 2014 · 10 comments
Closed

better version info #229

RemiArnaud opened this issue Feb 16, 2014 · 10 comments

Comments

@RemiArnaud
Copy link
Contributor

master branch converter should return 0.4.0 when asked version number (published dev-4). if fixes are done, it should say 0.4.1

dev branches should return 0.5.0-dev or the likes

this can be done using git tags

the git version number as of now is very useful, especially for dev branches. the converter can return that information as well, for example with --git which can return a string that can be used by git to clone the specific source

same goes for the .json

@fabrobinet
Copy link
Contributor

From the discussion we had and constraints we have, this is what I suggested:

  • tag master with the version it currently has
  • create builds matching new versions
  • JSON will have a version property
  • SPEC should mention a version that relates to the JSON one
  • There is no correlation between dev-x branch and version. some dev branch won't impact the format. But since we have to start somewhere, we will start from the dev-x number as suggested by Remi.

@pjcozzi
Copy link
Member

pjcozzi commented Mar 19, 2014

Sounds good but before tagging master, I'd like us to bring the converter in sync with the schema branch, and then make that the first labeled version.

@pjcozzi pjcozzi added this to the Draft 1.0 spec milestone Apr 30, 2014
@fabrobinet
Copy link
Contributor

@pjcozzi to be merged today, a version property at the root for now just like profile is. But I wonder if both profile and version wouldn't be better in asset....

@pjcozzi
Copy link
Member

pjcozzi commented May 13, 2014

But I wonder if both profile and version wouldn't be better in asset....

Sounds like the right move. I can update the schema quickly if you agree.

@fabrobinet
Copy link
Contributor

OK - let's do it. I'll move both properties under asset in the converter as well and that will be merged this way to master.

@pjcozzi
Copy link
Member

pjcozzi commented May 13, 2014

Updated. 95f843d

@fabrobinet
Copy link
Contributor

@pjcozzi I see for the version you used a string, but I used a float.
I may have misunderstood, but I thought during a call you asked for a number value.

@pjcozzi
Copy link
Member

pjcozzi commented May 13, 2014

You are right. Updated.

@fabrobinet
Copy link
Contributor

  • tagged master
  • created build for OS X and Windows Release. Sent email to @Khronoswebmaster to get the files uploaded so that we can link them from here.
  • version exported in JSON
  • @pjcozzi updated the spec with the version number.
  • reconverted sample models

@fabrobinet
Copy link
Contributor

This is now all done. We just to maintain applyging the process described here #229 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants