Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instanceSkin.sources or instanceSkin.meshes? #188

Closed
pjcozzi opened this issue Nov 12, 2013 · 4 comments
Closed

instanceSkin.sources or instanceSkin.meshes? #188

pjcozzi opened this issue Nov 12, 2013 · 4 comments

Comments

@pjcozzi
Copy link
Member

pjcozzi commented Nov 12, 2013

I'm still ramping up on skinning so I may be missing the semantics of using sources in instanceSkin to reference meshes, but wouldn't meshes be a better name since it is consistent with nodes that have just meshes?

Current naming:

            "instanceSkin": {
                "skeletons": [
                    "locator020Node",
                    "locator024Node"
                ],
                "skin": "Controller-mesh019",
                "sources": [
                    "Geometry-mesh019"
                ]
            },
@fabrobinet
Copy link
Contributor

I want to resolve #164 before taking decision on this one.

AFAIR, What I had originally in mind was to have source being potentially something else , e.g a morph but according to @tparisi we'll have both in parallel, and then we could introduce an array in node to specify the order of processing. So once we agree on that on #164 with the upcoming morph proposal, then we can be more restrictive here and use mesh in place of source.

@pjcozzi pjcozzi added this to the Draft 1.0 spec milestone Apr 30, 2014
@fabrobinet
Copy link
Contributor

ok with meshes for dev-7

@pjcozzi
Copy link
Member Author

pjcozzi commented Jul 7, 2014

0.8 spec updated in f3495a5.

@pjcozzi
Copy link
Member Author

pjcozzi commented Aug 27, 2015

The converter and schema are in sync.

@pjcozzi pjcozzi closed this as completed Aug 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants