Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should glTF specify unit property ? #23

Closed
fabrobinet opened this issue Mar 20, 2013 · 23 comments
Closed

should glTF specify unit property ? #23

fabrobinet opened this issue Mar 20, 2013 · 23 comments

Comments

@fabrobinet
Copy link
Contributor

No description provided.

@RemiArnaud
Copy link
Contributor

probably not, but converter needs to.

converter parameter: unit size in meter
then converter use the unit definition in the dae, and then apply the
scaling.

@fabrobinet
Copy link
Contributor Author

Sounds good to me.

@pjcozzi
Copy link
Member

pjcozzi commented Mar 20, 2013

@RemiArnaud does unit size in meters need to be a dae2json option? It is already part of COLLADA with the unit element of the asset element.

@RemiArnaud
Copy link
Contributor

the converter needs to know what unit to convert to, so yes, it is a
parameter to the converter.

the application need to deal with whatever it gets if it does not have
access to a converter? if yes, then specify the unit in the glTF as well.

@tparisi
Copy link
Contributor

tparisi commented Mar 20, 2013

There are only two choices: put a units metadata field in the format, or mandate glTF units (presumably at meters).

I'm ok with either, but I have a pretty strong preference for doing it the COLLADA way. That way artists and programmers can work in whatever they feel comfortable with and the engines/readers don't really care. They just have to convert from the specified units to their native runtime units. This doesn't seem to be broken in COLLADA, why fix it?

@RemiArnaud
Copy link
Contributor

I have been thinking about this one for quite some time.

I say - let's use 1 meter as the glTF unit.

We already say we are Y_UP, so it is aligned previous decisions. Surely make it simple to mash-up models from various part of the web - exact same coordinate system.

I have reviewed a bunch of use cases in my head, so ready for arguments now :-)

@pjcozzi
Copy link
Member

pjcozzi commented Apr 17, 2013

Any updates here?

I thought I originally included the unit element in asset from COLLADA, but I did not. I must have decided against it. Given that, I am OK with @RemiArnaud's proposal to define the units in meters, but don't have too strong of an opinion.

@ghost ghost assigned pjcozzi Apr 18, 2013
@pjcozzi
Copy link
Member

pjcozzi commented Oct 22, 2013

Any update?

@fabrobinet
Copy link
Contributor Author

I am fine with meters too...

@pjcozzi
Copy link
Member

pjcozzi commented Oct 22, 2013

Adding converter label since this will require converter support.

@pjcozzi
Copy link
Member

pjcozzi commented Jan 20, 2014

@fabrobinet any update on converter progress for this. There is some interest.

@fabrobinet
Copy link
Contributor Author

@pjcozzi what exactly needs to be done ? dev-4 is fully packed and I could use some help on this one :)

@pjcozzi
Copy link
Member

pjcozzi commented Jan 21, 2014

This would just rescale positions so that the units are meters if the input COLLADA units are not meters.

@meshula
Copy link

meshula commented Jan 21, 2014

I'm all for meters with the conversion @pjcozzi mentions. I've spent way too much time maintaining converters where units can change per file, and trying to work out what was intended when files with different units reference each other. Knowing that 1 == 1 no matter what sounds like heaven.

@fabrobinet
Copy link
Contributor Author

ok with me, we'll have to be careful of animations and make sure their translations are rescaled too...

@tparisi
Copy link
Contributor

tparisi commented Jan 21, 2014

I'm ok with this - as long as we understand that it puts all the onus on
the converter.

Tony

On Mon, Jan 20, 2014 at 8:14 PM, Fabrice Robinet
notifications@github.comwrote:

ok with me, we'll have to be careful of animations and make sure their
translations are rescaled too...


Reply to this email directly or view it on GitHubhttps://github.com//issues/23#issuecomment-32820180
.

Tony Parisi tparisi@gmail.com
CTO at Large 415.902.8002
Skype auradeluxe
Follow me on Twitter! http://twitter.com/auradeluxe
Read my blog at http://www.tonyparisi.com/
Learn WebGL http://learningwebgl.com/

Read my book! WebGL, Up and Running
http://shop.oreilly.com/product/0636920024729.do
http://www.amazon.com/dp/144932357X

@fabrobinet
Copy link
Contributor Author

Indeed, that's always the choice we make. More work on the converter, less work to import models for viewers&engines...

@pjcozzi
Copy link
Member

pjcozzi commented Jan 21, 2014

All sounds good. Good point about the animations.

@RemiArnaud
Copy link
Contributor

+1

-- Remi

On Tue, Jan 21, 2014 at 9:41 AM, Patrick Cozzi notifications@github.comwrote:

All sounds good. Good point about the animations.


Reply to this email directly or view it on GitHubhttps://github.com//issues/23#issuecomment-32909241
.

@yashafromrussia
Copy link

Hey, any update on this?

@fabrobinet
Copy link
Contributor Author

added for dev-7. Maybe @pjcozzi should you could look at with @tfili ? I guess it's important for cesium..

tfili pushed a commit to tfili/glTF that referenced this issue Jun 5, 2014
tfili pushed a commit to tfili/glTF that referenced this issue Jun 9, 2014
tfili pushed a commit to tfili/glTF that referenced this issue Jun 10, 2014
fabrobinet added a commit that referenced this issue Jul 8, 2014
@fabrobinet
Copy link
Contributor Author

Keeping for spec

@pjcozzi
Copy link
Member

pjcozzi commented Sep 16, 2015

@tparisi for the draft 1.0 spec, add:

Units are in meters.

tparisi added a commit that referenced this issue Sep 16, 2015
@tparisi tparisi closed this as completed Sep 16, 2015
donmccurdy pushed a commit to donmccurdy/glTF that referenced this issue Oct 11, 2021
…e-metadata

Restore EXT_feature_metadata alongside EXT_mesh_features
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants