Test new automated reference section #1899
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was not clear that "Material PBR Metallic Roughness" actually meant "material.pbrMetallicRoughness" as the type name.
Wetzel commit b9b3ce67552dfc6c106c10994da467a6190c7d75. Command line: $ bin/wetzel.js -l2 -a=cqo -m=a -p schema -i '["gltfchildofrootproperty.schema.json", "gltfid.schema.json", "gltfproperty.schema.json"]' ../glTF/specification/2.0/schema/glTF.schema.json > ../REFERENCE.adoc
|
Closing in favor of #1901. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big one. We probably don't want to merge this until the AsciiDoctor transition is ready to go.
Things that changed:
Schema titles have changed. It was not feasible for wetzel to parse what "Material PBR Metallic Roughness" meant in terms of the specific type name. So types like this now have a title of
material.pbrMetallicRoughessto match the type name.The reference section in README.md is the raw output from wetzel (see commit descriptions below).
A temporary
REFERENCE.adochas been added, to show what the AsciiDoctor version of the reference output looks like.Ultimately I do want to commit the schema title changes. But the README changes will become obsolete in the move to AsciiDoctor, and the REFERENCE section will be a temporary file during the AsciiDoctor build process, not preserved in git.