-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate latest AsciiDoc updates #2028
Conversation
lexaknyazev
commented
Sep 20, 2021
- Clarified Points and Lines rendering.
- More detailed explanation of sampler wrapping modes.
- Reordered and expanded skinning section.
- Added examples of non-ASCII paths.
- Removed the reference to the external extension document (it will be replaced anyway).
- Added references to GL-originated integer enum values.
- Minor tweaks, language and typography fixes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the skinning section.
Co-authored-by: Gary Hsu <bghgary@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is as clear as we can be on points & lines without introducing new properties.
Just in case, do you approve all other edits? |
Yes, everything in this PR looks good to me. |
One other question, and I hope this isn't too off-topic here, but: Can |
The spec says:
I think it's safe to say that it does not forbid such usage given that later the spec mentions morphing custom attributes. So let's mention WDYT? |
@bghgary or @donmccurdy Do you know if this would cause heartache for Babylon or ThreeJS? |
The missing spec part is the entries in the table with allowed accessor types. A similar fix is also needed for the Despite all these updates, I still see this as a bug fix because of the "at least" language. |
three.js will safely ignore morph attributes other than POSITION and NORMAL, so adding more (like
|