Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate latest AsciiDoc updates #2028

Merged
merged 6 commits into from
Sep 22, 2021
Merged

Conversation

lexaknyazev
Copy link
Member

  • Clarified Points and Lines rendering.
  • More detailed explanation of sampler wrapping modes.
  • Reordered and expanded skinning section.
  • Added examples of non-ASCII paths.
  • Removed the reference to the external extension document (it will be replaced anyway).
  • Added references to GL-originated integer enum values.
  • Minor tweaks, language and typography fixes.

Copy link
Contributor

@bghgary bghgary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the skinning section.

specification/2.0/Specification.adoc Outdated Show resolved Hide resolved
specification/2.0/Specification.adoc Outdated Show resolved Hide resolved
specification/2.0/Specification.adoc Outdated Show resolved Hide resolved
specification/2.0/Specification.adoc Outdated Show resolved Hide resolved
lexaknyazev and others added 2 commits September 20, 2021 22:23
Co-authored-by: Gary Hsu <bghgary@users.noreply.github.com>
Copy link
Member

@emackey emackey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is as clear as we can be on points & lines without introducing new properties.

@lexaknyazev
Copy link
Member Author

@emackey

I think this is as clear as we can be on points & lines without introducing new properties.

Just in case, do you approve all other edits?

@emackey
Copy link
Member

emackey commented Sep 21, 2021

Yes, everything in this PR looks good to me.

@emackey
Copy link
Member

emackey commented Sep 21, 2021

One other question, and I hope this isn't too off-topic here, but: Can TEXCOORD_0 be used as a morph target attribute? I'm pretty sure no one implements this, but is it forbidden by spec? I know of cases where it would be useful, particularly in scientific vis.

@lexaknyazev
Copy link
Member Author

Can TEXCOORD_0 be used as a morph target attribute?

The spec says:

Client implementations SHOULD support at least three attributes -- POSITION, NORMAL, and TANGENT -- for morphing.

I think it's safe to say that it does not forbid such usage given that later the spec mentions morphing custom attributes. So let's mention TEXCOORD_n and COLOR_n explicitly.

WDYT?

@emackey
Copy link
Member

emackey commented Sep 21, 2021

I think it's safe to say that it does not forbid such usage given that later the spec mentions morphing custom attributes. So let's mention TEXCOORD_n and COLOR_n explicitly.

@bghgary or @donmccurdy Do you know if this would cause heartache for Babylon or ThreeJS?

@lexaknyazev
Copy link
Member Author

The missing spec part is the entries in the table with allowed accessor types. A similar fix is also needed for the KHR_mesh_quantization extension that extends the table.

Despite all these updates, I still see this as a bug fix because of the "at least" language.

@emackey emackey merged commit 7748663 into KhronosGroup:jon-adoc Sep 22, 2021
@lexaknyazev lexaknyazev deleted the patch-1 branch September 22, 2021 15:23
@donmccurdy
Copy link
Contributor

donmccurdy commented Sep 28, 2021

three.js will safely ignore morph attributes other than POSITION and NORMAL, so adding more (like TEXCOORD_n or COLOR_n) shouldn't be any problem. I agree that the spec has been clear that this was a possibility. It would certainly be interesting to have workflows for morphing other attributes.

EDIT: three.js will probably struggle if targets use a mix of attributes, e.g. the first target morphs POSITION and the second morphs TEXCOORD_n. But we can fix that if the need arises.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants