fix: Added myself as contributor to KHR_materials_emissive_strength #2138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emackey
added a commit
that referenced
this pull request
May 23, 2022
KHR_materials_emissive_strength added. * initial commit for materials_emissive * change dir name * Update physical units, set default to 100. * Rename folder * Add emissive strength schema. * Fix leftover value from earlier draft. * Contributor list update * Revise default value and units descriptions based on recent discussion. * Update description to match jon-adoc branch. * Remove text redundant with core spec. * Remove section number, per offline review * Update to Release Candidate status * Update copyright message from main glTF registry. * Update contributors * fix: Added myself as contributor to KHR_materials_emissive_strength (#2138) * Changes per review * Mark KHR_materials_emissive_strength as ratified. Co-authored-by: Ben Houston <neuralsoft@gmail.com> Co-authored-by: Andreas Atteneder <andreas.atteneder@gmail.com>
proog128
pushed a commit
to DassaultSystemes-Technology/glTF
that referenced
this pull request
May 29, 2022
KHR_materials_emissive_strength added. * initial commit for materials_emissive * change dir name * Update physical units, set default to 100. * Rename folder * Add emissive strength schema. * Fix leftover value from earlier draft. * Contributor list update * Revise default value and units descriptions based on recent discussion. * Update description to match jon-adoc branch. * Remove text redundant with core spec. * Remove section number, per offline review * Update to Release Candidate status * Update copyright message from main glTF registry. * Update contributors * fix: Added myself as contributor to KHR_materials_emissive_strength (KhronosGroup#2138) * Changes per review * Mark KHR_materials_emissive_strength as ratified. Co-authored-by: Ben Houston <neuralsoft@gmail.com> Co-authored-by: Andreas Atteneder <andreas.atteneder@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@emackey I'd be happy to be on that list. Thanks!