Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tightening up animations #712

Merged
merged 7 commits into from
Sep 17, 2016
Merged

Tightening up animations #712

merged 7 commits into from
Sep 17, 2016

Conversation

lexaknyazev
Copy link
Member

@pjcozzi
Copy link
Member

pjcozzi commented Sep 13, 2016

@lexaknyazev can you please come up with a few concise bullets for this so we can update #605?

@lexaknyazev
Copy link
Member Author

This PR isn't ready yet: #704 (comment)

@pjcozzi
Copy link
Member

pjcozzi commented Sep 13, 2016

Content so far is big +1 from me. Once we finish the #704 conversation, I'll merge.

@pjcozzi
Copy link
Member

pjcozzi commented Sep 15, 2016

@lexaknyazev you should now have commit access to this repo so you can just merge this when you are happy.

You can also start doing work on branches in this repo, instead of a fork if you want, just please don't commit anything to master or 1.0.1 without a pull request.

@pjcozzi pjcozzi mentioned this pull request Sep 16, 2016
@pjcozzi
Copy link
Member

pjcozzi commented Sep 16, 2016

@lexaknyazev looks good, but doesn't the spec README.md need to be updated in addition to the schema files?

@lexaknyazev
Copy link
Member Author

Of course, I'll update readme before merging. Do we need to clarify anything else here?

@pjcozzi
Copy link
Member

pjcozzi commented Sep 16, 2016

No, I think it looks great.

@pjcozzi
Copy link
Member

pjcozzi commented Sep 17, 2016

@lexaknyazev is this ready now given 795580c?

@lexaknyazev
Copy link
Member Author

Not yet, I'm updating descriptions and examples now.

@lexaknyazev
Copy link
Member Author

@pjcozzi please review updated README.md and schema files.

@pjcozzi
Copy link
Member

pjcozzi commented Sep 17, 2016

Looks good, thanks @lexaknyazev!

Can you please update #605 (just edit the main comment) with a few bullets for this?

@pjcozzi pjcozzi merged commit 3174334 into KhronosGroup:1.0.1 Sep 17, 2016
@lexaknyazev
Copy link
Member Author

Done

@lexaknyazev lexaknyazev deleted the animations-fix branch September 17, 2016 16:16
lexaknyazev pushed a commit that referenced this pull request Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants