fix crash in HLSL frontend #2916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I think this change is fine and we just need to fix the failing test hlsl.emptystructreturn.frag. This can be done by building glslangtests.exe and running it with --update-mode enabled. Then commit the new *.out to your branch. |
|
Hi! |
fix crash, when converting HLSL return of hull shader into spirv/glsl like arrayed output. fix KhronosGroup#2914
arcady-lunarg
force-pushed
the
hull-shader-fix
branch
from
c053cba
to
a5f5206
Compare
|
I've rebased your PR on main and made a small change, with which the tests appear to pass and the crash no longer reproduces on your example. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix crash, when converting HLSL return of hull shader into spirv/glsl like arrayed output.
#fixed 2914