Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mesh shader: fix implicit index-array size calculation for lines and triangles #3050

Merged
merged 2 commits into from
Oct 31, 2022
Merged

mesh shader: fix implicit index-array size calculation for lines and triangles #3050

merged 2 commits into from
Oct 31, 2022

Conversation

Try
Copy link
Contributor

@Try Try commented Oct 16, 2022

Apparently compiler behavior wasn't updated to match EXT and still behaves like NV-version of mesh-shader.

#fixed #3041

@jeremy-lunarg
Copy link
Contributor

The tests need to be updated. Thanks.

@Try
Copy link
Contributor Author

Try commented Oct 19, 2022

I've run --update-mode on a failing test-cases. Yet, not 100% sure that this will work. Something is not quite right with my testing setup: locally I have way more test failures, mostly in unrelated cases

@greg-lunarg greg-lunarg added the kokoro:run Trigger Google bot runs label Oct 20, 2022
@kokoro-team kokoro-team removed the kokoro:run Trigger Google bot runs label Oct 20, 2022
@Try Try mentioned this pull request Oct 30, 2022
Closed
jeremy-lunarg
jeremy-lunarg approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@jeremy-lunarg jeremy-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix!

@jeremy-lunarg jeremy-lunarg merged commit 1a8869e into KhronosGroup:master Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremy-lunarg jeremy-lunarg jeremy-lunarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PrimitiveTriangleIndicesEXT array size not matching OutputPrimitivesEXT
4 participants
@Try @jeremy-lunarg @greg-lunarg @kokoro-team