Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Produce different names for files in debug builds on MSVC #311

Merged
merged 1 commit into from
Jun 2, 2016
Merged

Produce different names for files in debug builds on MSVC #311

merged 1 commit into from
Jun 2, 2016

Conversation

jherico
Copy link
Contributor

@jherico jherico commented May 25, 2016

Fix for #310

@johnkslang
Copy link
Member

Which file names are effected?

@jherico
Copy link
Contributor Author

jherico commented May 26, 2016

The lib file artifacts that are installed, specifically glslang.lib, HLSL.lib, OGLCompiler.lib, OSDependent.lib, and SPIRV.lib. With this PR, if you do a debug build in Visual Studio, each file gets a d suffix, like so glslangd.lib, HLSLd.lib, etc...

@jherico
Copy link
Contributor Author

jherico commented May 26, 2016

An alternative would be to modify the INSTALL targets so that the debug versions of the libraries are placed in a separate directory, but I don't know how to do that off the top of my head. using a d suffix is pretty common for this kind of thing in my experience.

@johnkslang
Copy link
Member

Okay, so this will impact all downstream uses that link a debug executable based on the existing names.

@jherico
Copy link
Contributor Author

jherico commented May 27, 2016

Potentially, but as it stands, anyone using cmake to create and build the MSVC version of this project would presumably already be having issues since the debug and release versions overwrite one another in the install directory. However, if someone is already working around that issue or has another build pipeline that..

  • uses MSVC
  • requires the debug libs as well as the release libs
  • has hardcoded the artifact names

Then yes they would have to update something.

@johnkslang
Copy link
Member

So, downstream users that want debug libraries will need to modify their build system to pick them up. Otherwise, they'll get the non-debug libraries no matter how glslang was built. Yes? I think that's okay, just giving a fair warning time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants