Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for GL_NV_displacement_micromap. #3324

Merged
merged 4 commits into from
Oct 2, 2023
Merged

Add support for GL_NV_displacement_micromap. #3324

merged 4 commits into from
Oct 2, 2023

Conversation

alelenv
Copy link
Contributor

@alelenv alelenv commented Aug 30, 2023

@arcady-lunarg
Copy link
Contributor

Does this depend on a change to spirv-tools (for the SPIR-V validator)? If so, that will need to be merged first and known_good.json updated so that the tests can pass. I can review the code changes here in the meantime however.

@alelenv
Copy link
Contributor Author

alelenv commented Sep 5, 2023

@arcady-lunarg : Nothing required in validator since just adds a few builtins and decorations. Can updated if anything else is expected
Yes will required headers to be merged before we can flip known_good

Thanks for reviewing

@alelenv
Copy link
Contributor Author

alelenv commented Sep 21, 2023

@arcady-lunarg : I have updated known_good and all tests are passing
Please re-review

Thanks

@arcady-lunarg arcady-lunarg added the kokoro:run Trigger Google bot runs label Sep 21, 2023
@kokoro-team kokoro-team removed the kokoro:run Trigger Google bot runs label Sep 21, 2023
@alelenv
Copy link
Contributor Author

alelenv commented Sep 27, 2023

@arcady-lunarg : Gentle one week ping!
Thanks

ncesario-lunarg
ncesario-lunarg reviewed Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@ncesario-lunarg ncesario-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM aside from the spirv-tools update, which will need to happen separately. @jeremy-lunarg I think we are planning on updating this soon?

@Kiskae Kiskae mentioned this pull request Sep 28, 2023
Merged
12 tasks
arcady-lunarg
arcady-lunarg requested changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@arcady-lunarg arcady-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor nit (the unused variable), otherwise this looks good.

SPIRV/GlslangToSpv.cpp Outdated Show resolved Hide resolved
@alelenv
Copy link
Contributor Author

alelenv commented Oct 2, 2023

@arcady-lunarg : Please approve and merge

arcady-lunarg
arcady-lunarg approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@arcady-lunarg arcady-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@arcady-lunarg arcady-lunarg added the kokoro:run Trigger Google bot runs label Oct 2, 2023
@kokoro-team kokoro-team removed the kokoro:run Trigger Google bot runs label Oct 2, 2023
@arcady-lunarg arcady-lunarg merged commit 3f02132 into KhronosGroup:main Oct 2, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncesario-lunarg ncesario-lunarg ncesario-lunarg left review comments

@arcady-lunarg arcady-lunarg arcady-lunarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alelenv @arcady-lunarg @ncesario-lunarg @kokoro-team