Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ASAN and TSAN integration testing #3343

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

ncesario-lunarg
Copy link
Collaborator

Add jobs for testing with -fsanitize=address and -fsanitize=thread.

Add jobs for testing with -fsanitize=address and -fsanitize=thread.
Guard global variables 'CompileFailed' and 'LinkFailed' in the
StandAlone application with atomics.
@ncesario-lunarg ncesario-lunarg changed the title Add ASAN integration testing Add ASAN and TSAN integration testing Sep 26, 2023
Copy link
Contributor

@arcady-lunarg arcady-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have one question about the atomics, otherwise this looks good, thanks for getting it done.

StandAlone/StandAlone.cpp Show resolved Hide resolved
Copy link
Contributor

@arcady-lunarg arcady-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@arcady-lunarg arcady-lunarg merged commit b0ed478 into KhronosGroup:main Sep 29, 2023
22 checks passed
@ncesario-lunarg ncesario-lunarg deleted the asan branch September 29, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants