Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always enable the generation of OpDebugBasicType for bool type #3379

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Always enable the generation of OpDebugBasicType for bool type #3379

merged 1 commit into from
Dec 7, 2023

Conversation

chaocNV
Copy link
Contributor

@chaocNV chaocNV commented Oct 25, 2023

Fixing issue #3376

arcady-lunarg
arcady-lunarg requested changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@arcady-lunarg arcady-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem right, if you look at the changes in the test results it's generating the debug type multiple times and massively increasing the number of IDs used. You need to make sure the bool debug type only gets emitted once.

@chaocNV
Copy link
Contributor Author

chaocNV commented Nov 30, 2023

This doesn't seem right, if you look at the changes in the test results it's generating the debug type multiple times and massively increasing the number of IDs used. You need to make sure the bool debug type only gets emitted once.

Fixed. Could you help merge?

@chaocNV
Copy link
Contributor Author

chaocNV commented Dec 5, 2023

A friendly pain on review/merge @ncesario-lunarg @arcady-lunarg

arcady-lunarg
arcady-lunarg approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@arcady-lunarg arcady-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was putting me off was the fact that your change makes the SPIR-V smaller, but it is actually because the current version of the code apparently repeatedly generates OpDebugTypeBasic for bool, whereas after your change it is only generated once. So your change is making things more correct.

@arcady-lunarg arcady-lunarg merged commit 9a35abf into KhronosGroup:main Dec 7, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arcady-lunarg arcady-lunarg arcady-lunarg approved these changes

@ncesario-lunarg ncesario-lunarg ncesario-lunarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chaocNV @ncesario-lunarg @arcady-lunarg