Add iOS build to CI #3409
Merged
Add iOS build to CI #3409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix iOS build as well as minor Android cleanup since the problems for both platforms are so similar
ncesario-lunarg
approved these changes
Nov 21, 2023
|
FYI @richard-lunarg |
juan-lunarg
commented
Nov 21, 2023
Comment on lines
+71
to
+72
| set(ENABLE_GLSLANG_BINARIES OFF) | ||
| set(SPIRV_SKIP_EXECUTABLES ON) |
There was a problem hiding this comment.
For extra context the ndk-builds currently in glslang and spirv-tools also don't create executables. For the aforementioned reasons.
There was a problem hiding this comment.
So this should also speed up our Android / iOS CI in downstream repos since we can avoid building extra executables.
arcady-lunarg
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix iOS build as well as minor Android cleanup since the problems for both platforms are so similar