Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove OGLCompiler and HLSL stub libraries from build #3426

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Remove OGLCompiler and HLSL stub libraries from build #3426

merged 1 commit into from
Nov 29, 2023

Conversation

juan-lunarg
Copy link
Contributor

Fixes ranlib warnings complaining about empty archive libraries.

Simplifie build/code.

@juan-lunarg
Copy link
Contributor Author

Fixes ranlib warnings complaining about empty archive libraries.

These are the warnings I'm talking about

 -- Installing: /Users/runner/work/glslang/glslang/build/install/lib/libHLSL.a
/Applications/Xcode_14.3.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: build/install/lib/libHLSL.a(stub.cpp.o) has no symbols
warning: /Applications/Xcode_14.3.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: archive library: build/install/lib/libHLSL.a the table of contents is empty (no object file members in the library define global symbols)

-- Installing: /Users/runner/work/glslang/glslang/build/install/lib/libOGLCompiler.a
/Applications/Xcode_14.3.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: build/install/lib/libOGLCompiler.a(InitializeDll.cpp.o) has no symbols
warning: /Applications/Xcode_14.3.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: archive library: build/install/lib/libOGLCompiler.a the table of contents is empty (no object file members in the library define global symbols)

@juan-lunarg
Remove OGLCompiler and HLSL stub libraries from build
47f202f 
Fixes ranlib warnings complaining about empty archive libraries.

Simplifie build/code.
@arcady-lunarg arcady-lunarg merged commit 6be56e4 into KhronosGroup:main Nov 29, 2023
27 checks passed
@juan-lunarg juan-lunarg deleted the juan/remove_stubs branch November 29, 2023 17:32
This was referenced Nov 29, 2023
Closed
Merged
Closed
juan-lunarg added a commit to KhronosGroup/Vulkan-ValidationLayers that referenced this pull request Nov 29, 2023
@juan-lunarg
tests: Remove usage of unused glslang libraries
0488e25 
KhronosGroup/glslang/pull/3426 removed the OGLCompiler and HLSL
stub libraries.

Furthermore there was no reason for us to link OSDependent,
MachineIndependent, GenericCodeGen, and glslang.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arcady-lunarg arcady-lunarg arcady-lunarg approved these changes

@ncesario-lunarg ncesario-lunarg ncesario-lunarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juan-lunarg @ncesario-lunarg @arcady-lunarg