support GL_ARB_texture_multisample extension. #3430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncesario-lunarg
requested changes
Nov 29, 2023
There was a problem hiding this comment.
Probably not the desired output?
There was a problem hiding this comment.
Thank you for your reminder, I have update the test file and expected result file.
|
|
||
| if (builtIn && (fnCandidate->getBuiltInOp() == EOpTextureFetch || fnCandidate->getBuiltInOp() == EOpTextureQuerySize)) { | ||
| TString typeName = (*fnCandidate)[0].type->getSampler().getString(); | ||
| if ((typeName == "sampler2DMS" || typeName == "sampler2DMSArray") && version == 140) |
There was a problem hiding this comment.
I think this makes sense after looking at the spec, but just to clarify, this extension is only required for version 140? i.e., it is not possible to use this extension prior to 140?
There was a problem hiding this comment.
Thanks for your suggesstion, I have made modifications to this PR.
This extension allows the use of "texelFetch" and "textureSize" with 2DMS sampler.
jimihem
force-pushed
the
GL_ARB_texture_multisample
branch
from
0b6cb32 to
671c1d3
Compare
ncesario-lunarg
approved these changes
Nov 30, 2023
Test/GL_ARB_texture_multisample.vert
Outdated
Comment on lines
10
to
13
| result = texelFetch(data, ivec2(0), 3).r; | ||
| ivec2 temp = textureSize(data); | ||
| result = texelFetch(data1, ivec3(0), 3).r; | ||
| ivec3 temp1 = textureSize(data1); |
There was a problem hiding this comment.
It might be nice if these were indented. Not sure if we want that enforced @arcady-lunarg?
There was a problem hiding this comment.
I have organized the format @ncesario-lunarg
arcady-lunarg
requested changes
Dec 13, 2023
jimihem
force-pushed
the
GL_ARB_texture_multisample
branch
from
ea5bcdf to
f507bbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extension allows the use of "texelFetch" and "textureSize" with 2DMS sampler.
#version 140
out float result;
uniform sampler2DMS data;
uniform sampler2DMSArray data1;
void main()
{
result = texelFetch(data, ivec2(0), 3).r;
ivec2 temp = textureSize(data);
result = texelFetch(data1, ivec3(0), 3).r;
ivec3 temp1 = textureSize(data1);
}