Bug fix, code optimization, small ux changes #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o, repositioned Add Button
…would not be saved
mvnowak
commented
Mar 22, 2022
| @@ -12,6 +12,7 @@ | |||
| android:theme="@style/Theme.Sobriety"> | |||
| <activity | |||
| android:name=".Create" | |||
| android:windowSoftInputMode="adjustResize" | |||
There was a problem hiding this comment.
This is necessary, to display the Snackbar "Can't create entries with duplicate keys" above the opened keyboard.
|
Looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug that would allow adding entries with duplicate names => 2 distinct elements would be displayed in the list, but only 1 would be saved due to identical keys in the hash map
Replaced prompt updating via looper with distinct update calls when:
Moved Floating Action Button further away from the screen edge to make it more accessible, changed icon tint to white
Fixed typo in description