Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Oscillator: Add Oscillator_SMD_DiodesPericom_FN-4Pin_7.0x5.0mm #1538

Conversation

gmsotavio
Copy link
Collaborator

@gmsotavio gmsotavio commented Apr 7, 2019

Screenshot_2019-04-07_19-00-16

Manf. Doc: https://www.diodes.com/assets/Datasheets/FN_3-3V.pdf


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@myfreescalewebpage myfreescalewebpage added Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer labels Apr 8, 2019
@evanshultz evanshultz self-assigned this Apr 8, 2019
@evanshultz
Copy link
Collaborator

  1. Get rid of the "Pericom" part of the footprint name.
  2. The fab layer needs a pin 1 mark. This would be easy enough to do with straight sides and one bevel instead of rounded corners, but you can keep the rounded corners too. What ideas do you have?
  3. Courtyard should be 0.25mm bigger than the part body or pads. It seems you used 0.5mm? http://kicad-pcb.org/libraries/klc/F5.3/ mentioned canned crystals but this can use the normal SMD rule.

@gmsotavio
Copy link
Collaborator Author

gmsotavio commented Apr 9, 2019

@evanshultz, thanks for the suggestions!

Get rid of the "Pericom" part of the footprint name.

Done.

The fab layer needs a pin 1 mark. This would be easy enough to do with straight sides and one bevel instead of rounded corners, but you can keep the rounded corners too. What ideas do you have?

Done. I have kept the rounded corners for a while, but something says me that you prefer straight sides with no rounded corners. Drop me a line and I will change this. I have no personal preference. You decide!

Courtyard should be 0.25mm bigger than the part body or pads. It seems you used 0.5mm? http://kicad-pcb.org/libraries/klc/F5.3/ mentioned canned crystals but this can use the normal SMD rule.

Fixed! In my mind I was drawing a crystal but it is an SMD Oscillator.

Screenshot_2019-04-08_23-33-27

@evanshultz
Copy link
Collaborator

Thanks! The pin 1 fab line mark varies a lot in this library so we'll go with it. Eventually there could be a standard but that time is not now.

@evanshultz evanshultz merged commit 8d3abf0 into KiCad:master Apr 9, 2019
@antoniovazquezblanco antoniovazquezblanco removed the Pending reviewer A pull request waiting for a reviewer label Apr 9, 2019
@antoniovazquezblanco antoniovazquezblanco modified the milestones: 6.0.0, 5.1.1 Apr 9, 2019
DaToBSn pushed a commit to DaToBSn/kicad-footprints that referenced this pull request Jul 2, 2019
* 'master' of github.com:KiCad/kicad-footprints:
  Add 3.5x3.5mm QFN-20 with 2mm pad. (KiCad#1543)
  RF_Module: Fix issues of HOPERF_RFM9XW_THT (KiCad#1346) (KiCad#1347)
  Added USB_A SS-52100-001 connector (KiCad#1468)
  Add Texas RGE0024C footprint (KiCad#1395)
  Add shield pads (KiCad#1390)
  Add RF_WiFi folder and footprint support of USR-C322 3MBps WiFi module
  Add Texas RNN0018A for TPS568215 (KiCad#1466)
  Add footprint for RTC RV-1805-C3 (KiCad#1505)
  Oscillator: Add Oscillator_SMD_DiodesPericom_FN-4Pin_7.0x5.0mm (KiCad#1538)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants