Fix footprints of RECOM DC/DC converters

[rschaeuble]

Fix footprints of RECOM DC/DC converters, where the 'bulge' was toward the back while it should have been to the front.

These changes bring the 3D models in sync with changes in the footprints. See this pull request for details: KiCad/kicad-footprints#688.

Here are the changes to the generator script: easyw/kicad-3d-models-in-freecad#178.

Sizes, colors/material properties etc. were left unchanged.

Screenshots of alignment:

R78B-2.0:

R-78HB-0.5:

---

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items as you complete them:

• A screenshot of the model(s) aligned with KiCad footprints is very useful
• Was the 3D model(s) created in a mechanical modelling program?
  • Models were created by a script.
• Source files (or scripts) have been contributed
  • Fix footprint of RECOM DC/DC adapters. easyw/kicad-3d-models-in-freecad#178
• Step model submitted in 1:1 scale
• WRL model submitted in 1:2.54 scale
• 3D model alignment checked against KiCad footprint
• WRL model uses correct material properties
  • I modified already existing model files; no changes to colors/material AFAICT.
• Geometry check performed against mechanical models
  • I did not make any changes to the geometry.

[CLAassistant]

All committers have signed the CLA.

[rschaeuble]

I noticed that the sources repo for the 3D models does not contain any source files for these DC/DC converters. Would a FreeCAD source file be a welcome addition?

As I need a footprint and a 3D model for another RECOM converter which KiCad's library does not yet include, I'm going to build one soon anyway. As most of the RECOM converters are very similar, I could just create the other models, too.

[Shackmeister]

There is no freecad files since they are scriptet. You can find the script here: https://github.com/easyw/kicad-3d-models-in-freecad/blob/master/cadquery/FCAD_script_generator/Converter_DCDC/main_generator_Converter_DCDC.py it would be great if you can fix it in the script (and possibly make you models through that)

[rschaeuble]

I installed the "cadquery_module" add-on in FreeCad and tried to run the generator script, but so far I had no luck:

"\Program Files\FreeCAD 0.17\bin\FreeCADCmd.exe" Converter_DCDC\main_generator_Converter_DCDC.py

Result:

Exception while processing file: Converter_DCDC/main_generator_Converter_DCDC.py [No module named exportPartToVRML]

I tried adding -M exportVRML and -P exportVRML, but then I got the following error:

Exception while processing file: Converter_DCDC/main_generator_Converter_DCDC.py ['module' object has no attribute 'getMainWindow']

Any idea what I am doing wrong?

[Shackmeister]

Did you download the entire repo and not just the script?

[rschaeuble]

Yes, I cloned the complete Git repo, and executed the command from my previous comment in the folder "cadquery\FCAD_script_generator" of the clone.

[Shackmeister]

Try going into Converter_DCDC/
And run: \Program Files\FreeCAD 0.17\bin\FreeCAD.exe main_generator_Converter_DCDC.py

Ofcourse replace your path to freecad.Exe

[rschaeuble]

Still the same result: ['module' object has no attribute 'getMainWindow'].

Then I executed just FreeCADCmd.exe, which put my into an interactive python shell. There I tried the following:

import FreeCADGui
FreeCADGui.getMainWindow()

Result: AttributeError: 'module' object has no attribute 'getMainWindow'
It seems that in FreeCadCMD.exe there is no access to GUI classes, so I tried using "FreeCad.exe". After some attempts, I found that the following command, executed in the "Converter_DCDC" folder, works:
"\Program Files\FreeCAD 0.17\bin\FreeCAD.exe" main_generator_Converter_DCDC.py all.

It seems that now all the DC/DC generator models have been generated.

Now it's time for some sleep. Tomorrow I'll try to fix the model data in the generator, and recreate the correct models.

[Shackmeister]

Great! Looking forward to see your work :) remember V5 is coming out in a week or so, so we gotta be Swift to get the fix in V5 :)

[rschaeuble]

Done :)

I have submitted a pull request for the generator script, and I have updated this pull request with the model files created by the generator.

Btw.: when submitting new models or fixes to existing ones, is there any preferred order for pull requests for generator, 3D models, footprints etc.? I figure it would be somewhat suboptimal if some but not all of those pull requests were accepted.

[poeschlr]

All of them should exist at the same time. We librarians take care of the rest. (Remember to link between the pull requests. So that we know which ones are connected.)

[Shackmeister]

Thank you for the fast and proper fix :) hope to see more contributions from you

[evanshultz]

To go into a bit more depth: we merge the generator last, in the belief that models/footprints/symbols will get to correctness during their PR and after that then the generator is fine.