Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

ADC1173 symbol in library Analog_ADC.lib is wrong #1165

Closed
FrankBuss opened this issue Nov 24, 2018 · 2 comments
Closed

ADC1173 symbol in library Analog_ADC.lib is wrong #1165

FrankBuss opened this issue Nov 24, 2018 · 2 comments
Assignees
Labels
Bug Fix symbol existing in the library

Comments

@FrankBuss
Copy link

Pin AIN is wrong, it is pin 19, not pin 27. There is no pin 27 in a TSSOP24 package.

@evanshultz evanshultz self-assigned this Nov 24, 2018
@evanshultz evanshultz mentioned this issue Nov 24, 2018
5 tasks
@evanshultz
Copy link
Collaborator

Hi Frank,

It appears this is the first contribution to KiCad! Thanks for taking the time to contact the librarian team, and sorry that it's because you found a possible error.

You are absolutely right:
image

Pin 19 should be named "VIN" according to the datasheet as well.

I've submitted a PR to fix this symbol at #1167. I wanted to get this fix implemented right away so I went ahead and made the PR, but in the future if you find an issue you're welcome to submit a PR yourself, if you wish.

Thanks again!

@antoniovazquezblanco antoniovazquezblanco added the Bug Fix symbol existing in the library label Nov 26, 2018
@antoniovazquezblanco
Copy link
Collaborator

PR merged! Please @FrankBuss check if this solves your issue and feel free to reopen the issue if not.

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Fix symbol existing in the library
Projects
None yet
Development

No branches or pull requests

2 participants