Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Fix ADC1173 VIN pin #1167

Merged
merged 1 commit into from
Nov 26, 2018
Merged

Fix ADC1173 VIN pin #1167

merged 1 commit into from
Nov 26, 2018

Conversation

evanshultz
Copy link
Collaborator

Also change pin name offset to 20mil and shorten pin length to 100mil (while keeping same pin locations).

Datasheet:http://www.ti.com/lit/ds/symlink/adc1173.pdf.

Since this is a bug and should be quick to review, while not breaking anything, I'd like to get it into 5.0.2.

See #1165.

image


Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required

Also change pin name offset to 20mil and shorten pin length to 100mil (while keeping same pin locations).
@evanshultz evanshultz added the Bug Fix symbol existing in the library label Nov 24, 2018
@evanshultz evanshultz added this to the 5.0.2 milestone Nov 24, 2018
@antoniovazquezblanco
Copy link
Collaborator

Closing and reopening the issue for CLA fixing.

@antoniovazquezblanco
Copy link
Collaborator

Just a note on GH features. If you use the keywords "Fixes #issuenumber" in your PR description, GitHub will automatically close the referenced issue once the PR is merged.

@antoniovazquezblanco antoniovazquezblanco merged commit dbe689e into KiCad:master Nov 26, 2018
@evanshultz evanshultz deleted the adc1173 branch November 26, 2018 16:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Fix symbol existing in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants