Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Timer: S5.1 and S5.2 errors #953

Open
antoniovazquezblanco opened this issue Sep 18, 2018 · 4 comments
Open

Timer: S5.1 and S5.2 errors #953

antoniovazquezblanco opened this issue Sep 18, 2018 · 4 comments
Labels
Good first issue If you are new and want to collaborate this is a good issue to begin Help wanted Workforce is very welcomed KLC issue

Comments

@antoniovazquezblanco
Copy link
Collaborator

KLC Rules:
http://kicad-pcb.org/libraries/klc/S5.1/
http://kicad-pcb.org/libraries/klc/S5.2/

Splitting issue #28 I have found the following violations:

Checking symbol '8284':
  Violating S5.1
    For components with a single default footprint, footprint field is filled with valid footprint
    filename
    Footprint filter 'PDIP*W7.62mm*' does not match the footprint 'Package_DIP:DIP-18_W7.62mm' set for this symbol.
     - could not match 'DIP-18_W7.62mm' against filter 'PDIP*W7.62mm*'
     - could not match 'Package_DIP:DIP-18_W7.62mm' against filter 'PDIP*W7.62mm*'
    Symbol has a footprint defined in the footprint field, but several (2) footprint filters set. If the symbol is for a single default footprint, remove the surplus filters. If the symbol is meant for multiple different footprints, empty the footprint field.
checking ruleS5.2
checking ruleS5.1
Checking symbol '82C54':
  Violating S5.1
    For components with a single default footprint, footprint field is filled with valid footprint
    filename
    Footprint filter 'PDIP*W15.24mm*' does not match the footprint 'Package_DIP:DIP-24_W15.24mm' set for this symbol.
     - could not match 'DIP-24_W15.24mm' against filter 'PDIP*W15.24mm*'
     - could not match 'Package_DIP:DIP-24_W15.24mm' against filter 'PDIP*W15.24mm*'
    Symbol has a footprint defined in the footprint field, but several (2) footprint filters set. If the symbol is for a single default footprint, remove the surplus filters. If the symbol is meant for multiple different footprints, empty the footprint field.
@antoniovazquezblanco antoniovazquezblanco added Help wanted Workforce is very welcomed KLC issue Good first issue If you are new and want to collaborate this is a good issue to begin labels Sep 18, 2018
@serkanxselcuk
Copy link
Contributor

serkanxselcuk commented Sep 18, 2018

Hi @antoniovazquezblanco ,

Footprint filter 'PDIPW7.62mm' does not match the footprint 'Package_DIP:DIP-18_W7.62mm' set for this symbol.
- could not match 'DIP-18_W7.62mm' against filter 'PDIPW7.62mm'
- could not match 'Package_DIP:DIP-18_W7.62mm' against filter 'PDIPW7.62mm'

You filtered PDIP*W7.62mm* but set footprint as DIP-18_W7.62mm, which cannot be found using filter. KLC shows this as error. I would try to set filter ?DIP*W7.62mm*, *DIP*W7.62mm* or DIP*W7.62mm*.

@antoniovazquezblanco
Copy link
Collaborator Author

antoniovazquezblanco commented Sep 18, 2018

Yes, I know. I am trying to compile a list of known library issues like this one. By splitting all this errors into small batches I hope that both us librarians and collaborators like you can improve the library in small increments.

This comes from a big issue (#28) that covered a lot of symbols. I wouldn't know when to close that issue, and for that reason I am splitting it into more manageable tasks.

If you decide to help us solve any of this issues please just let us know with a comment.

Thank you very much @serkanxselcuk!

@serkanxselcuk
Copy link
Contributor

Oh, I see. I thought you try to import new component. :) Thank you for focus on old issues.

@serkanxselcuk
Copy link
Contributor

@antoniovazquezblanco
I remember my first message here :)

evanshultz pushed a commit that referenced this issue Sep 29, 2020
* 8284 KLC errors fixed.

* 82C45 and 82C45_PLCC klc errors fixed.

* 8284 and 82C54 pin length fixed to 100 mil

* second ~ is removed on inverted pins
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Good first issue If you are new and want to collaborate this is a good issue to begin Help wanted Workforce is very welcomed KLC issue
Projects
None yet
Development

No branches or pull requests

2 participants