Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Cleaned up issues from MCU_NXP_Kinetis.lib #128

Merged
merged 7 commits into from
Jan 15, 2018
Merged

Cleaned up issues from MCU_NXP_Kinetis.lib #128

merged 7 commits into from
Jan 15, 2018

Conversation

DerekGn
Copy link
Contributor

@DerekGn DerekGn commented Jan 3, 2018

Cleanup from #25
Fixed footprints
Stacked power pins
Modified symbols to use datasheet labels

Question:
A number of symbols have an extra pin called EPAD for example MKL04Z32VFM4 should this be removed?


Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required

DerekGn added 2 commits January 3, 2018 21:55
@poeschlr
Copy link
Collaborator

poeschlr commented Jan 3, 2018

About the EPAD pin:
I assume this represents the exposed pad found in the packages. Normally these pins should have the pin number one higher than the normal pin numbers. The footprint should then have the name [package name]-[number of pins]-1EP-...

Your example MKL04Z32VFM4 has Package_DFN_QFN:QFN-32-1EP_5x5mm_P0.5mm assigned.
As you can see here it has a pad with number 33 (Same number as the pin EPAD):
screenshot from 2018-01-04 00-03-29

@DerekGn
Copy link
Contributor Author

DerekGn commented Jan 3, 2018

Cool just wanted to check

Another Q, since kicad AFAIK cant do vias without trace, how can this extra pin be tied to ground?

This was the reason for my question in the PR above.

@poeschlr
Copy link
Collaborator

poeschlr commented Jan 4, 2018

Kicad can not have vias that are not connected to a pad (Either using a trace to connect to a pad or placing the via directly into the pad work to have the via connected.)

@DerekGn
Copy link
Contributor Author

DerekGn commented Jan 4, 2018

OK thanks for the info

@DerekGn DerekGn changed the title WIP: Cleaned up issues from MCU_NXP_Kinetis.lib Cleaned up issues from MCU_NXP_Kinetis.lib Jan 5, 2018
@poeschlr
Copy link
Collaborator

poeschlr commented Jan 7, 2018

Re running scripts can be triggered by closing and reopening the pull request.

Is this ready for review?

@DerekGn
Copy link
Contributor Author

DerekGn commented Jan 8, 2018

Yes this branch can be reviewed.
The footprints where merged recently.

@poeschlr
Copy link
Collaborator

Looks good. Thanks

@poeschlr poeschlr merged commit 2c615cc into KiCad:master Jan 15, 2018
@DerekGn DerekGn deleted the MCU_NXP_Kinetis branch January 18, 2018 20:59
@myfreescalewebpage myfreescalewebpage added the Enhancement Improves existing symbol in the library label May 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement Improves existing symbol in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants