Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Fix Issue1391 #1445

Merged
merged 4 commits into from
Mar 25, 2019
Merged

Fix Issue1391 #1445

merged 4 commits into from
Mar 25, 2019

Conversation

gmsotavio
Copy link
Collaborator

@gmsotavio gmsotavio commented Jan 20, 2019 •
edited
Loading

Fix #1391. Additionally, I've fixed the broken datasheet links of the moved symbols.

Otavio Gomes

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required

@myfreescalewebpage myfreescalewebpage added Bug Fix symbol existing in the library Pending reviewer A pull request waiting for a reviewer labels Jan 20, 2019
@evanshultz
Copy link
Collaborator

Let's wait until after 5.1 is tagged to do this. Also, branch conflicts.

@evanshultz evanshultz mentioned this pull request Mar 5, 2019
Closed
@evanshultz
Copy link
Collaborator

@gmsotavio
5.1 is tagged so we can review this again once you solve branch conflicts.

The only thing I see now is that RFM95W-868S2 can have the question mark changed to an asterisk in the footprint filter and also remove the SMD* and THT*, leaving just a single filter, which will act exactly the same but be more resilient.

@evanshultz evanshultz self-assigned this Mar 11, 2019
@antoniovazquezblanco antoniovazquezblanco removed the Pending reviewer A pull request waiting for a reviewer label Mar 11, 2019
@myfreescalewebpage myfreescalewebpage mentioned this pull request Mar 23, 2019
Closed
@gmsotavio
Copy link
Collaborator Author

gmsotavio commented Mar 24, 2019 •
edited
Loading

@evanshultz I've solved the branch conflicts and changed the footprint filter as you suggested. Please, check the changes carefully, because I've never solved conflicts before. Sorry by delayed job in this PR and thank you for your patience.

@evanshultz
Copy link
Collaborator

You fixed the conflict properly. Thanks! All looks well. I appreciate you taking the time to improve the library!

@evanshultz evanshultz merged commit 20c87d6 into KiCad:master Mar 25, 2019
@antoniovazquezblanco antoniovazquezblanco added this to the 6.0.0 milestone Mar 25, 2019
@poeschlr poeschlr mentioned this pull request Apr 8, 2019
Closed
@antoniovazquezblanco antoniovazquezblanco added Enhancement Improves existing symbol in the library and removed Bug Fix symbol existing in the library labels Apr 12, 2019
@poeschlr
Copy link
Collaborator

This one really is at the brink for being allowed into v5.1.1. I am sure i would have advised against merging if i would have seen this in time. (I simply did not have the time lately to check everything.) As it stands i will allow it to stay in and take full responsibility for any problems that emerge for our users.

@poeschlr poeschlr modified the milestones: 6.0.0, 5.1.1 Apr 14, 2019
DaToBSn pushed a commit to DaToBSn/kicad-symbols that referenced this pull request Jul 2, 2019
Merge branch 'master' of github.com:KiCad/kicad-symbols
ec0a719 
* 'master' of github.com:KiCad/kicad-symbols: (55 commits)
  Create LT3748 (KiCad#1600)
  TXB0304RUT and TXBN0304RUT (KiCad#1683)
  Added ZXMP4A16GTA P-Channel FET (KiCad#1684)
  RF Module: Add CMWX1ZZABZ (KiCad#1424)
  Relay: Add RT3 family (KiCad#1409)
  Update MCU_STC.dcm
  fixes based on review
  Update MCU_STC.dcm
  pins 2.54mm
  Fix dcm file
  Added TSV994
  Change DIP?14* to DIP*W7.62mm*
  split into 2 units
  Update MCU_STC.lib
  Fix fp for LM2574HVM (correct body size number format) (KiCad#1485)
  Typo + reorder sym-lib-table (KiCad#1680)
  Fix Issue1391 (KiCad#1445)
  Fix line endings
  Change 74LS07 to alias
  GND pin type set to Power Input
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@evanshultz evanshultz

Labels
Enhancement Improves existing symbol in the library
Projects
None yet
Milestone
5.1.1
Development

Successfully merging this pull request may close these issues.

RFM69, RFM95W and variants are in the wrong symbol library
5 participants
@gmsotavio @evanshultz @poeschlr @antoniovazquezblanco @myfreescalewebpage