-
Notifications
You must be signed in to change notification settings - Fork 742
Conversation
|
@evanshultz thanks for the review.
Joel |
2.Can you clarify what you mean? Our "standard" linear regulator symbol, with just 3 pins, is small and tight with VIN on the left side. But here I'm not understanding why VIN can't be on top. Let me know what you're thinking? |
@evanshultz you are thinking to the "Regulator_Linear" library. This one is in "Regulator_Switching" and is like many other. Just have a look to all symbols in this one. |
Yes, I know. I was giving an example of a library where we specifically decided to put a power pin on the side in violation of KLC. Here, why can't VIN be on the top to conform with KLC? No downside that I can see. Other legacy symbols in this lib don't but we can't change them so I say to leave them alone but recognize they're not a good reference for the current library guidelines. |
Well, I have accepted many pull request in regulator switching library with input voltage on the left. Compared to the regulator linear library, I don't see any functional differences, this is a regulator with current flowing from the input to the output as shown on the above schema. VIN on the top will look like a little bit strange I think. However I agree this not apply to regulator that drive a FET with a transformer like the LT3748 I have proposed in #1600. Joel |
Just seen pull request of @SchrodingersGat at #1710 that have VIN to the top. Not bad anyway. However, this is not the traditional way to draw this kind of regulator, even the datasheet has: |
The library is designed to KLC, and http://kicad-pcb.org/libraries/klc/S4.2/ says power pins should be on top. There are a no exceptions listed. Yet when Jan reworked the linear reg lib it was decided to make simple 3-terminal linear regs have VIN on the left. We both know KLC doesn't cover everything, by design, but sadly I haven't been proactive in keeping it updated where new info would clearly be helpful. And while each vendor may have their own style for making symbols that doesn't mean it matches KLC. As you said there are many switching regulator symbols with VIN on the side today, but we can stick closer to KLC starting now to reduce the number of abnormalities. Or we can decide to make more exceptions or abolish this clause of KLC. My point is that I can't see a downside to doing what KLC says in this example. I will merge this and I raised the VIN pin position on switching regulator symbols at #1711. There are many other undecided topics floating around so it's just another item on the list. |
I agree with you, we have to decide globally if this is an exception for all regulators, or not and in this case a work will need to be done across the library before v6 :) |
I think that logically for regulators it makes sense to have the VIN pin(s) on the top left of the symbol. This is currently what we do for all the linear regs. |
@SchrodingersGat take care, this is not top, this is side. Precisely on the top of the left side :) |
Sorry you're right, I didn't express that very well.
|
@SchrodingersGat I know you know :) |
Footprint is merged and CI is green. So... merge this? |
@evanshultz I cannot do it I'm the author :) |
Right. I'm making sure you're ready for me to merge it. And it sounds like you are. |
I am :) |
Add Texas TPS568215
All contributions to the kicad library must follow the KiCad library convention
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:
http://www.ti.com/lit/ds/symlink/tps568215.pdf
KiCad/kicad-footprints#1466