Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add LMZ13608 #1716

Merged
merged 7 commits into from
May 2, 2019
Merged

Add LMZ13608 #1716

merged 7 commits into from
May 2, 2019

Conversation

ottojo
Copy link
Contributor

@ottojo ottojo commented Apr 7, 2019

Add LMZ13608

This adds the symbol for the LMZ13608 Power Module (TI Product Page)
8A DC/DC Buck Converter, 6-36V Input

PR for footprint at KiCad/kicad-footprints#1532.

LMZ13608


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@CLAassistant
Copy link

CLAassistant commented Apr 7, 2019

CLA assistant check
All committers have signed the CLA.

@ottojo ottojo marked this pull request as ready for review April 7, 2019 03:38
@myfreescalewebpage myfreescalewebpage added Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer labels Apr 7, 2019
@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Apr 7, 2019

Hi @ottojo , thanks for contributing,

A few comments I have during my review:

  • Description package name should be Texas NDY0011A: 8A Adjustable Step-Down DC/DC Power Module in 15x15mm, Texas NDY0011A is great
  • Footprint can be Package_LGA:Texas_NDY0011A according to me and footprint filter should be Texas*NDY0011A*
  • Name of pin 9 should be NC
  • Number of pin PAD should be 12
  • Symbol is too tall compared to other similar devices, proposition below

Capture

Cheers,
Joel

@myfreescalewebpage myfreescalewebpage self-assigned this Apr 7, 2019
@myfreescalewebpage myfreescalewebpage added Pending footprint Pending footprint acceptance before merging and removed Pending reviewer A pull request waiting for a reviewer labels Apr 7, 2019
Change package name to "Texas NDY0011A"
Fix symbol size
@myfreescalewebpage
Copy link
Collaborator

Thanks for the fixes, no more comment, just need to wait for the footprint now :)

@evanshultz
Copy link
Collaborator

I'm reviewing the footprint. A couple thoughts:

  1. Should the ground pin be named AGND? Usually we will copy the datasheet pin names and the main pin name, and the visible pin name, is AGND.
  2. Is U the right ref des prefix for a module? https://github.com/KiCad/kicad-symbols/blob/master/Converter_DCDC.lib uses a mixture of U and PS. For what it's worth, IEE 315-1975 shows PS is used for "power supply" and "rectifier (complete power-supply assembly)".

@myfreescalewebpage
Copy link
Collaborator

@evanshultz
1- I was wondering about the same think during the review. I have not asked the modification, "AGND" looks strange for me since this is a regulator.
2- Not bad, I have no personal preference. Maybe we need to log an issue to decide about that and parse the whole library to get it consistent with U or PS ?

@evanshultz
Copy link
Collaborator

  1. That's what the datasheet says...
  2. Agreed. Would you mind to start the issue?

@myfreescalewebpage
Copy link
Collaborator

  1. It's also PGND depending if you consider the PGND to be the main GND pin (see block diagram page 14 of the datasheet)
  2. Sure!

@myfreescalewebpage
Copy link
Collaborator

Issue about references at #1727

ottojo added 2 commits April 11, 2019 21:48
Page 1 in the datasheet shows a schematic symbol with separate AGND and PGND.
@myfreescalewebpage
Copy link
Collaborator

@ottojo ok for this proposition separating the ground pins.
Waiting for the footprint before merging.
Joel

@myfreescalewebpage
Copy link
Collaborator

@ottojo footprint has been merged but you need to change the footprint here (footprint library has changed).
Joel

@myfreescalewebpage myfreescalewebpage removed the Pending footprint Pending footprint acceptance before merging label May 2, 2019
@myfreescalewebpage
Copy link
Collaborator

Thanks, merging.

@myfreescalewebpage myfreescalewebpage merged commit 8af39ce into KiCad:master May 2, 2019
@ottojo ottojo deleted the LMZ13608 branch May 2, 2019 21:40
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.3 milestone May 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants