This repository has been archived by the owner on Oct 2, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniovazquezblanco
added
Addition
Adds new symbols to library
Pending reviewer
A pull request waiting for a reviewer
labels
May 20, 2019
myfreescalewebpage
removed
the
Pending reviewer
A pull request waiting for a reviewer
label
May 29, 2019
Hi @cronJ , thanks for contributing, A few comments I have during my review:
Maybe a symbol more tall than large is better, I'm not sure yet. If you wish to submit ADN4650 and ADN4651 too, it's a pleasure to review them too! Cheers, |
* Add "SSOP-20" to the end of description * Change footprint filter to "SSOP*5.3x7.2mm*P0.65mm*" * Add isolation barrier * Add missing pin 9 (VDD1) * Add missing pin 12 (VDD2)
@cronJ that's great, thanks. As indicated above, pin 9 and pin 12 should NOT be stacked. The datasheet indicate two capacitorS are required on the pins, we do not stack positive power pin in this case in the library. |
@myfreescalewebpage |
Yes it is, sorry, I was not here this week ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Analog ADN4652
Created from https://www.analog.com/media/en/technical-documentation/data-sheets/adn4650-4651-4652.pdf
All contributions to the kicad library must follow the KiCad library convention
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items: