Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add Analog ADN4652 #1868

Merged
merged 5 commits into from
Jun 22, 2019
Merged

Add Analog ADN4652 #1868

merged 5 commits into from
Jun 22, 2019

Conversation

cronJ
Copy link
Contributor

@cronJ cronJ commented May 20, 2019

Add Analog ADN4652

Created from https://www.analog.com/media/en/technical-documentation/data-sheets/adn4650-4651-4652.pdf

image


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@antoniovazquezblanco antoniovazquezblanco added Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer labels May 20, 2019
@myfreescalewebpage myfreescalewebpage self-assigned this May 29, 2019
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label May 29, 2019
@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented May 29, 2019

Hi @cronJ , thanks for contributing,

A few comments I have during my review:

  • Description should ends with the package name, please add , SSOP-20 at the end
  • Footprint filter should be SSOP*5.3x7.2mm*P0.65mm*
  • The isolation barrier should be indicate with a dash line. For example you can look at ISO1050DUB device in the library
  • Pin 9 is missing (VDD1, not to be stacked with pin 3)
  • Pin 12 is missing (VDD2, not to be stacked with pin 3)

Maybe a symbol more tall than large is better, I'm not sure yet.

If you wish to submit ADN4650 and ADN4651 too, it's a pleasure to review them too!

Cheers,
Joel

* Add "SSOP-20" to the end of description
* Change footprint filter to "SSOP*5.3x7.2mm*P0.65mm*"
* Add isolation barrier
* Add missing pin 9 (VDD1)
* Add missing pin 12 (VDD2)
@cronJ
Copy link
Contributor Author

cronJ commented May 29, 2019

Hi,

I implemented the requested changes.

Here is the PR for ADN4650
Here is the PR for ADN4651

Best regards.

@myfreescalewebpage
Copy link
Collaborator

@cronJ that's great, thanks. As indicated above, pin 9 and pin 12 should NOT be stacked. The datasheet indicate two capacitorS are required on the pins, we do not stack positive power pin in this case in the library.
Joel

This was referenced May 30, 2019
@evanshultz
Copy link
Collaborator

@myfreescalewebpage
Is this PR ready to be merged?

@myfreescalewebpage
Copy link
Collaborator

Yes it is, sorry, I was not here this week !
Merging.

@myfreescalewebpage myfreescalewebpage merged commit 0d18e9d into KiCad:master Jun 22, 2019
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.3 milestone Jun 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants