Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add Wuerth 171050601 #1878

Merged
merged 2 commits into from
Jun 3, 2019
Merged

Add Wuerth 171050601 #1878

merged 2 commits into from
Jun 3, 2019

Conversation

cronJ
Copy link
Contributor

@cronJ cronJ commented May 23, 2019

Add Wuerth 171050601

Created from https://katalog.we-online.de/pm/datasheet/171050601.pdf

image


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@myfreescalewebpage myfreescalewebpage added Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer labels May 23, 2019
@myfreescalewebpage myfreescalewebpage self-assigned this May 31, 2019
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label May 31, 2019
@myfreescalewebpage
Copy link
Collaborator

Closing/opening to refresh the CLA.

@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented May 31, 2019

Hi @cronJ , thanks for contributing,

A few comments I have during my review:

  • Description should ends with the package name: MagI3C Power Module, Variable Step Down Regulator Module, 6 to 36V Input Voltage, 0.8 to 6V, 5A Output, TO-263
  • Footprint filter should be TO*263*TabPin8* (no pin count in FP filter)
  • Name of pin 4 is "AGND"
  • Pin 8 should not be stacked with pin 4 for this symbol to allow wiring as shown on page 1 of the datasheet. Pin 8 should be called "PGND"
  • You can put Reference in top left corner and Name in top right corner to increase visibility of th symbol:

Capture

Cheers,
Joel

* Move package name to end of description
* Change footprint filter
* Rename pin 4 to AGND
* Move besides pin 8
* Rename pin 8 to PGND
* Move reference and name
@myfreescalewebpage
Copy link
Collaborator

Thanks, no more comment, merging.

@myfreescalewebpage myfreescalewebpage merged commit 423f4f6 into KiCad:master Jun 3, 2019
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.3 milestone Jun 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants