Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Added NCP1529 #1906

Merged
merged 2 commits into from
Jun 14, 2019
Merged

Added NCP1529 #1906

merged 2 commits into from
Jun 14, 2019

Conversation

Trubochkin
Copy link
Contributor

@Trubochkin Trubochkin commented Jun 6, 2019

SharedScreenshot


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@antoniovazquezblanco antoniovazquezblanco added Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer labels Jun 6, 2019
@myfreescalewebpage myfreescalewebpage self-assigned this Jun 7, 2019
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Jun 7, 2019
@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Jun 7, 2019

Hi @Trubochkin , thanks for contributing,

A few comments I have during my review:

  • The name of the device should be "NCP1529A" to avoid conflict with the other package option
  • The symbol should be an alias of "TLV62568DBV" already in the library

Cheers,
Joel

@myfreescalewebpage
Copy link
Collaborator

Thanks, no more comment, merging.

@myfreescalewebpage myfreescalewebpage merged commit 44acd44 into KiCad:master Jun 14, 2019
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.3 milestone Jun 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants