Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Change BC8[45]6BS footprint filters #1970

Merged
merged 2 commits into from
Jul 12, 2019
Merged

Conversation

chschlue
Copy link
Contributor

Fixes issue #951


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@evanshultz evanshultz self-assigned this Jul 12, 2019
@evanshultz
Copy link
Collaborator

@chschlue
Thanks for taking on a bug fix with your first contribution here!

We want to go about this a bit differently. Since these are fully-specified parts with a defined package in the datasheet, we will keep the existing default footprint. But the footprint filters can remove all but SOT?363*. That should work.

@myfreescalewebpage myfreescalewebpage added the Enhancement Improves existing symbol in the library label Jul 12, 2019
@chschlue
Copy link
Contributor Author

@evanshultz like so?

@evanshultz
Copy link
Collaborator

Indeed. Thank you!

@evanshultz evanshultz merged commit 99de761 into KiCad:master Jul 12, 2019
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.3 milestone Jul 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement Improves existing symbol in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants