-
Notifications
You must be signed in to change notification settings - Fork 742
Conversation
Thanks for your contribution. A few comments from a first review:
Many thanks! |
One stack for the VDDA pins and one other stack for the VDDA3P3 pins.
I hadn't seen that you may need caps between VP and CAPP and between VN and CAPN.
The SENSOR_* signals are connected to the ESP32 chip inside the PICO package, so they can be used. I think they are fine on the left-hand side.
They are GPIO9 and GPIO10. Maybe place them in that order?
Thanks again! |
Thanks for the changes. The stacking pins look good!
Thanks! |
It is arbitrary. I was simply trying to:
So that was why I suggested that order.
Have in mind that the order of pins for that memory which Espressif used in their schematics is arbitrary too. It could be different, for instance see the symbol for 25LCxxx in the KiCad library which has the same signals. So I'm not sure trying to match the order of their memory symbol is necessary. Thanks! |
Thanks for all the changes.
A couple of comments regarding the description.
So I think it should be: RF Module, ESP32 SoC, Wi-Fi 802.11b/g/n, Bluetooth, BLE, 32-bit, 2.7-3.6V, external antenna, QFN-48
RF Radio BT ESP ESP32 Espressif external antenna We're nearly there :) Thanks! |
Thanks again for the changes. Just on thing pending: IO09 still has an extra zero. Can you fix it? Thanks! |
Looks good. Merging. Many thanks for your contribution and all the changes done. I hope you continue contributing to KiCad. |
And thank you for the many reviews too |
Push of ESP32-PICO-D4
https://www.espressif.com/sites/default/files/documentation/esp32-pico-d4_datasheet_en.pdf
Checking symbol 'ESP32-PICO-D4':
Violating S4.4
Pin electrical type should match pin function
Pin types should match pin function
- Pin CLK (31) @ (900,500) is type BIDI : suggested INPUT
CLK can be used as input and output
All contributions to the kicad library must follow the KiCad library convention
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items: