-
Notifications
You must be signed in to change notification settings - Fork 742
Conversation
These don't have an exposed pad, of course
Just a couple quick notes since I'm not assigned to this PR:
|
Okay, updated. |
Thanks!
|
Thanks! Can you post screenshots of all symbols for ease of checking and for reference? |
@diegoherranz |
Thank you both for creating/updating and reviewing this. I didn't have much time lately to look into this. My main comment would be that this is a USB<->SPI converter, so I would think of having the USB pins on one side of the chip and the SPI ones on the opposite one. What would you think about having the USB pins on the top right above the GPx? Then RST could move to the top left and the SPI ones could move slightly up. What do you guys think about that? That would make it somewhat more similar to the current MCP2200 symbols, and also to the duplicate PR for this symbol, #2127. Thanks! |
Thanks for the changes. That looks good to me. What do you think, @evanshultz? (note that the symbols on the previous comment have been updated). I've just noticed that the VUSB pin may work better as passive since it can be power input or power output, depending on the power arrangement. Thanks! |
IMO the MCP2200 symbols are so old and ugly they're a bad reference. But I'm more in favor of just getting this merged. Changing the VUSB pin type sounds OK and I think it's nicer if that pin is closer to D+/D- (so swap positions with pin 1) but then let's get this done. |
It was more having USB on one side and SPI on the other than really making it look like the MCP2200. But coincidentally, that matches the MCP2200. |
Thanks, I think it looks OK now. Merging. |
Sorry for coming after the merge. |
I see your point. I guess the symbol would become a bit taller, but it may be OK. Do you want to give it a try on a different PR based on this symbol? Normally we can't move the pin locations of existing symbols to avoid breaking schematics, but this symbol hasn't made it into any stable release so I think it would be OK. Please, @KiCad/librarians, shout otherwise!
Yes, I guess it can be connected to GND, but to turn it into a hidden GND pin it should be clearly specified in the datasheet that it must/shall be connected to GND. I don't think it's clear enough and I would leave it as is where the user has the choice. Thanks! |
By the way, that PR would need to happen before 5.1.5 is tagged, which may not be far :) |
Done. |
In QFN, SOIC, and SSOP variants, matching other Microchip ICs.
All contributions to the kicad library must follow the KiCad library convention
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items: