Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

add LM74700-Q1 ideal diode controller #2221

Merged
merged 1 commit into from
Oct 2, 2019

Conversation

florolf
Copy link
Contributor

@florolf florolf commented Oct 1, 2019

Add the LM74700-Q1 ideal diode controller.

Symbol passes the linter. Datasheet link: http://www.ti.com/lit/gpn/LM74700-Q1

Screenshot:

2019-10-01-224539_1354x959_scrot

The pin positions are chosen such that default-sized symbols fit easily:

2019-10-01-224808_705x820_scrot


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@evanshultz evanshultz self-assigned this Oct 2, 2019
@evanshultz
Copy link
Collaborator

Thanks for this contribution!

  1. I only see this in automotive, but let's still remove the -Q1 from the symbol name.
  2. End the description with the package, in this case , SOT-23-6.
  3. Let's make pin 1 Passive type.
  4. I'm unsure about pin 6. I'm thinking it should be Power Input to help catch a mistake where the net on that pin is not a power source. What do you think?

N.B.: There currently only exists an automotive variant of this chip
(with the -Q1 suffix). After some discussion in the PR, we decided to
canonicalize the part name by dropping the suffix.
@florolf
Copy link
Contributor Author

florolf commented Oct 2, 2019

Thanks for looking into the PR.

  1. I only see this in automotive, but let's still remove the -Q1 from the symbol name.

There's no non-automotive version at the moment, so I thought we should consider the suffix as a part of the proper name. But sure, let's drop it.

  1. End the description with the package, in this case , SOT-23-6.

Done.

  1. Let's make pin 1 Passive type.

Okay, I was unsure about this one.

  1. I'm unsure about pin 6. I'm thinking it should be Power Input to help catch a mistake where the net on that pin is not a power source. What do you think?

You're right. From the point of view of the chip, this actually is a power input: It powers the charge pump as well as the logic.

@evanshultz
Copy link
Collaborator

Thanks. Please don't force push as it makes it harder for the librarians to review your changes.

@evanshultz evanshultz merged commit 7ccba72 into KiCad:master Oct 2, 2019
@antoniovazquezblanco antoniovazquezblanco added the Addition Adds new symbols to library label Oct 3, 2019
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.5 milestone Oct 3, 2019
pull bot pushed a commit to maximeborges/kicad-symbols that referenced this pull request Oct 5, 2019
N.B.: There currently only exists an automotive variant of this chip
(with the -Q1 suffix). After some discussion in the PR, we decided to
canonicalize the part name by dropping the suffix.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants