Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add AT45DB161D-SU DataFlash #2223

Merged
merged 3 commits into from
Oct 7, 2019
Merged

Add AT45DB161D-SU DataFlash #2223

merged 3 commits into from
Oct 7, 2019

Conversation

gggfred
Copy link
Contributor

@gggfred gggfred commented Oct 2, 2019

Datasheet
imagen


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@diegoherranz diegoherranz added Pending reviewer A pull request waiting for a reviewer Addition Adds new symbols to library labels Oct 2, 2019
@cpresser
Copy link
Contributor

cpresser commented Oct 5, 2019

Hi and thanks for the contribution.

  • Travis complains about the FP filter to be to specific. Please fix that.
  • The symbol seems to be a copy of the existing AT25* from the current lib. Which brings some problems:
  1. It can't be a drop in replacement-symbol for the other AT45* parts
  2. The pin names are wrong (IO? not found in the data-sheet). Does this device even support DSPI or QSPI modes?

I suggest you copy the existing symbol AT45DB161-JC instead, remove the busy pin, renumber pins and adjust footprint and fp-filter.

@cpresser cpresser self-assigned this Oct 5, 2019
@cpresser cpresser removed the Pending reviewer A pull request waiting for a reviewer label Oct 5, 2019
@gggfred
Copy link
Contributor Author

gggfred commented Oct 7, 2019

@cpresser ok, it's done

@cpresser cpresser merged commit 263f6f0 into KiCad:master Oct 7, 2019
@gggfred gggfred deleted the at45db161d branch October 7, 2019 16:27
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.5 milestone Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants