Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

add RJ45 ethernet connector Pulse JXD6-0001NL #2229

Merged
merged 1 commit into from
Oct 16, 2019
Merged

Conversation

hvraven
Copy link
Contributor

@hvraven hvraven commented Oct 3, 2019

This adds a ethernet magjack from Pulse (datasheet). Symbol is based on the existing Würth 7499010121A. Matching footprint in KiCad/kicad-footprints#1887

Screenshot_20191003_192912


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@cpresser cpresser added Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer Pending footprint Pending footprint acceptance before merging labels Oct 5, 2019
@cpresser cpresser removed the Pending footprint Pending footprint acceptance before merging label Oct 16, 2019
@cpresser cpresser self-assigned this Oct 16, 2019
@cpresser cpresser removed the Pending reviewer A pull request waiting for a reviewer label Oct 16, 2019
@cpresser
Copy link
Contributor

cpresser commented Oct 16, 2019

Looks good. I like that you connected the shield in the symbol.
One thing I would like to see improved is description/keywords.

  • There is no mention of the fact that this is a magjack.

edit I just realized it says 'transformer'. Which is good enough, all the other similar parts have the same keywords. And Magjack is a trademark after all.

@cpresser cpresser merged commit 9c85e84 into KiCad:master Oct 16, 2019
@hvraven hvraven deleted the jxd6 branch October 16, 2019 21:07
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.5 milestone Oct 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants