Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add LME49600 high current audio buffer #2232

Merged
merged 3 commits into from
Oct 8, 2019
Merged

Conversation

qberthet
Copy link
Contributor

@qberthet qberthet commented Oct 3, 2019

Datasheet

Screenshot from 2019-10-04 00-23-06
)

All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@evanshultz evanshultz self-assigned this Oct 4, 2019
@cpresser cpresser added Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer and removed Pending reviewer A pull request waiting for a reviewer labels Oct 5, 2019
@evanshultz
Copy link
Collaborator

Thanks for contributing and welcome!

  1. Can you change 250mA Audio Buffer in the description to Headphone Buffer, 250mA?
  2. Then add the package (TO-263) at the end of the description with a comma separator.
  3. Pin 3 should be Power Input type.

@qberthet
Copy link
Contributor Author

qberthet commented Oct 8, 2019

Done, V- as passive was a vestige of an aborted stacked pin approach, sorry

Updated screenshots:
Screenshot from 2019-10-08 19-44-18
Screenshot from 2019-10-08 19-44-36

@evanshultz
Copy link
Collaborator

The changes above are done correctly, but the datasheet should not be in the LIB file, only the DCM file. See the latest commit. Can you fix that and then I can merge?

@qberthet
Copy link
Contributor Author

qberthet commented Oct 8, 2019

Hum, didn't change that, is it because I updated my kicad install to current master since I started the symbol?

Should I edit it by hand?

@evanshultz evanshultz merged commit 8043f88 into KiCad:master Oct 8, 2019
@evanshultz
Copy link
Collaborator

Yes. See http://kicad-pcb.org/libraries/klc/G1.8/. In fact, a more strongly-worded and complete guideline for this clause is under review now.

@qberthet
Copy link
Contributor Author

qberthet commented Oct 8, 2019

Ok, thanks, will update my other pull request

@qberthet qberthet deleted the LME49600 branch October 8, 2019 18:20
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.5 milestone Oct 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants