Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Fixed symbol with boundingbox offset #2239

Merged

Conversation

fabikroeger
Copy link
Contributor

Fixed symbol with boundingbox offset at part A of the symbol

Before fix:
P4080_before

After fix:
p4080_after

I did not touch anything else on that symbol so i do not fill any checkbox below!


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@CLAassistant
Copy link

CLAassistant commented Oct 8, 2019

CLA assistant check
All committers have signed the CLA.

@antoniovazquezblanco antoniovazquezblanco added Enhancement Improves existing symbol in the library Pending reviewer A pull request waiting for a reviewer labels Oct 8, 2019
@evanshultz evanshultz self-assigned this Oct 8, 2019
@evanshultz
Copy link
Collaborator

Oops! Thanks for catching this error and submitting the fix. And welcome!

You will need to sign the CLA above before I can merge this, but it looks ready to merge once you do.

@fabikroeger
Copy link
Contributor Author

Hey, thank you! It was pure coincidence that i got that bug... i misstyped a symbol name while searching for a device within the lib and that came up :-D

@evanshultz
Copy link
Collaborator

Unfortunately there are many symbols that are old and with problems. This one especially need a lot of love but that won't happen during KiCad 5.x. Thanks again!

@evanshultz evanshultz merged commit 7485d61 into KiCad:master Oct 8, 2019
@fabikroeger fabikroeger deleted the CPU_P4080-BGA1295_box_offset_fix_part_A branch October 8, 2019 16:44
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.5 milestone Oct 9, 2019
@antoniovazquezblanco antoniovazquezblanco removed the Pending reviewer A pull request waiting for a reviewer label Oct 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement Improves existing symbol in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants