Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add LP5036 LED driver #2247

Merged
merged 4 commits into from
Nov 13, 2019
Merged

Add LP5036 LED driver #2247

merged 4 commits into from
Nov 13, 2019

Conversation

rleh
Copy link
Contributor

@rleh rleh commented Oct 16, 2019

@CLAassistant
Copy link

CLAassistant commented Oct 16, 2019

CLA assistant check
All committers have signed the CLA.

@cpresser cpresser added Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer Pending footprint Pending footprint acceptance before merging labels Oct 17, 2019
@cpresser
Copy link
Contributor

Hi,
it seems like there is no footprint for this yet.
Did you also submit a PR for that? If yes, please put a link here.

@rleh
Copy link
Contributor Author

rleh commented Oct 17, 2019

Footprint Pull-Request is here: KiCad/kicad-footprints#1922 and pointhi/kicad-footprint-generator#445

@rleh rleh force-pushed the Driver_LED__LP5036 branch from cf7d00d to c270b3d Compare October 28, 2019 09:15
@rleh
Copy link
Contributor Author

rleh commented Oct 28, 2019

The footprint has been merged.

I force-pushed my commit to restart Travis-CI and detect my typo in the footprint name.
Now fixed!

@cpresser cpresser removed the Pending footprint Pending footprint acceptance before merging label Oct 29, 2019
@cpresser
Copy link
Contributor

cpresser commented Oct 29, 2019

  • SCL should be an input
  • GND pins should be stacked
  • Please move IREF, VCAP to the bottom of the left side. They will be connected to GND via resistor, cap, so putting them there will make the connections short.
  • Similar to the above point, I suggest to move the ADDR? pins to either the top or bottom of the left side for easier wiring up.

@cpresser cpresser self-assigned this Oct 29, 2019
@cpresser cpresser added Pending changes User is expected to perform fixes before merging and removed Pending reviewer A pull request waiting for a reviewer labels Oct 29, 2019
@rleh
Copy link
Contributor Author

rleh commented Nov 4, 2019

Updated symbol:
grafik

@cpresser
Copy link
Contributor

cpresser commented Nov 8, 2019

Thanks, I did update the checklist in the above post.
👍 for the updated screenshot!
One more thing, the pin-stack should have the pin with the lowest number visible and set as power.
That does not seem to be codified in the KLC. But we do handle it that way.

@rleh
Copy link
Contributor Author

rleh commented Nov 9, 2019

I updated the symbol again, pin 37 (lowest number) is now visible.
I had thought about which GND pin should be visible, but found nothing in the KLC. Thanks for the info!

@cpresser cpresser merged commit 493c5fa into KiCad:master Nov 13, 2019
@cpresser
Copy link
Contributor

Thanks. #Leistungswolf

@cpresser cpresser removed the Pending changes User is expected to perform fixes before merging label Nov 13, 2019
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.5 milestone Nov 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants