Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Fix SG-8002LB pinname #2248

Merged
merged 2 commits into from
Oct 17, 2019
Merged

Conversation

cpresser
Copy link
Contributor

Pin4 is called Vcc, not V+

This came up when working on #2173

https://support.epson.biz/td/api/doc_check.php?dl=brief_SG5032CAN&lang=en

Pin4 is called Vcc, not V+
@antoniovazquezblanco antoniovazquezblanco added Bug Fix symbol existing in the library Enhancement Improves existing symbol in the library Pending reviewer A pull request waiting for a reviewer labels Oct 17, 2019
@evanshultz evanshultz self-assigned this Oct 17, 2019
@evanshultz
Copy link
Collaborator

The datasheet above doesn't point to the right device. https://support.epson.biz/td/api/doc_check.php?dl=brief_SG-8002LB&lang=en is the right datasheet and it confirms the pin name change. Can you update the datasheet?

And what about the other SG-8002 devices? Can you also fix their pin name and datasheet URL?

@cpresser
Copy link
Contributor Author

The datasheet in this post was a copy&paste error.
I still had it around for the #2173 PR.

I think I got all SG-8002 devices now. Some actually had the wrong datasheet.
Some look like its wrong, but one datasheet has info on most of the parts.

@evanshultz
Copy link
Collaborator

Thanks!

@evanshultz evanshultz merged commit 5b11dff into KiCad:master Oct 17, 2019
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.5 milestone Oct 21, 2019
@antoniovazquezblanco antoniovazquezblanco removed the Pending reviewer A pull request waiting for a reviewer label Oct 21, 2019
@cpresser cpresser deleted the Fix_SG-8002LB_pinname branch October 29, 2019 19:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Fix symbol existing in the library Enhancement Improves existing symbol in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants