Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

added NCP662 #2501

Closed
wants to merge 4 commits into from
Closed

added NCP662 #2501

wants to merge 4 commits into from

Conversation

Knochi
Copy link
Contributor

@Knochi Knochi commented Feb 17, 2020

added ON-Semi Low Dropout Regulator NCP662 Series in common fixed voltages 1.5V, 1.8V, 3.3V and 5.0V.


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library

Regulator_Linear_NCP662SQ15T1G

@myfreescalewebpage myfreescalewebpage added Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer labels Feb 19, 2020
@CLAassistant
Copy link

CLA assistant check
All committers have signed the CLA.

@cpresser
Copy link
Contributor

Hi and thanks for you contribution!
This looks like its the first symbol to use the SC-82AB package.

There are a few things that should be addressed before I can merge this:

  • Description and keywords are good
  • Package is good
  • Footprint-Filter should not start with an *
  • I would like to wait for travis-ci to generate a result. Unsure why it fails. I did restart the build, but it still fails. I will investigate this, but are open to suggestions as well.
  • The pin-names are not correct, they should be VIN and VOUT.
  • The T1G suffix should be removed. It is non-functional.
    image

@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Mar 22, 2020
@cpresser cpresser added the Pending changes User is expected to perform fixes before merging label Mar 31, 2020
@myfreescalewebpage
Copy link
Collaborator

@Knochi ping, are you still alive on this subject ?

@Knochi
Copy link
Contributor Author

Knochi commented Sep 22, 2020

@Knochi ping, are you still alive on this subject ?

Ah yes.. sorry
will have a look

hmm pushing to my repo doesn't seem to work.

@myfreescalewebpage
Copy link
Collaborator

Did you manage to get it working ? Just inform us so the ongoing status of this PR is clear for us

@myfreescalewebpage
Copy link
Collaborator

Just seen the new PR you have done, for the future you should keep your branch until the PR is merged, and you can simply push to your branch to update the PR. Continue the review on the other PR.

@myfreescalewebpage myfreescalewebpage self-assigned this Sep 22, 2020
@myfreescalewebpage myfreescalewebpage mentioned this pull request Sep 22, 2020
@myfreescalewebpage myfreescalewebpage added the Abandoned Original author has stopped working on the PR label Oct 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Abandoned Original author has stopped working on the PR Addition Adds new symbols to library Pending changes User is expected to perform fixes before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants